Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Ignore doc tests which "Broken MIR" ICE occurred" #1685

Merged
merged 3 commits into from
Jul 1, 2019

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 26, 2019

This reverts commit 2d12746.

ICE has been fixed in rust-lang/rust#61872.

Closes #1657

@taiki-e

This comment has been minimized.

@taiki-e

This comment has been minimized.

@taiki-e
Copy link
Member Author

taiki-e commented Jun 29, 2019

Somehow Travis uses an older version of rustc.

https://travis-ci.com/rust-lang-nursery/futures-rs/jobs/212000679

$ rustc --version
rustc 1.37.0-nightly (5f9c0448d 2019-06-25)

@Nemo157
Copy link
Member

Nemo157 commented Jun 29, 2019

info: updating existing rustup installation

Looks like they recently added rustup to their base image, which breaks their initialization script as it only tries to install nightly and doesn't update it.

@cramertj cramertj merged commit efcae3b into rust-lang:master Jul 1, 2019
@taiki-e taiki-e deleted the docs-ignored branch July 2, 2019 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some doc tests fail with ICE
4 participants