Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rand(_core) #1664

Closed
wants to merge 1 commit into from
Closed

Update rand(_core) #1664

wants to merge 1 commit into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jun 6, 2019

This may not be completely fixable. (It seems that some versions have already been yanked...)

@seanmonstar
Copy link
Contributor

I don't really understand why it's recommended to use such version ranges for rand_core. Since it defines the traits, a program can't compile if there's multiple rand_core versions in the tree, as the traits don't match...

futures-util/Cargo.toml Outdated Show resolved Hide resolved
@taiki-e
Copy link
Member Author

taiki-e commented Jun 6, 2019

rand has a lot of sub crates, which are not always updated at the same time.
And when releasing a new minor version of rand_core, they also publish the new patch version of old minor version, which has been changed to re-export the new minor version (0.3, 0.2).
So, this may cause compilation to fail if Cargo.lock is not completely up-to-date. This can also be caused by the dependency using an older version.

@Nemo157
Copy link
Member

Nemo157 commented Jun 6, 2019

rust-random/rand#819 looks like 0.5 may be yanked soon.

@taiki-e
Copy link
Member Author

taiki-e commented Jun 6, 2019

Hmm... still fail. ICE is will be avoided in #1658.
#1658 is out-of-date, so I rebased it. looks like some rand* crates have been yanked, so it may work well without rand updates.

@taiki-e
Copy link
Member Author

taiki-e commented Jun 6, 2019

#1658 works well.

@taiki-e
Copy link
Member Author

taiki-e commented Jun 6, 2019

Postpone this PR until there is something upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants