Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FromStr implementation for Oid #91

Merged
merged 1 commit into from
Jan 13, 2016
Merged

Add FromStr implementation for Oid #91

merged 1 commit into from
Jan 13, 2016

Conversation

hauleth
Copy link
Contributor

@hauleth hauleth commented Jan 13, 2016

This will allow Oid parsing with str::parse.

This will allow `Oid` parsing with `str::parse`.
@alexcrichton
Copy link
Member

Oh wow I'm not sure why this wasn't here in the first place... thanks!

alexcrichton added a commit that referenced this pull request Jan 13, 2016
Add `FromStr` implementation for `Oid`
@alexcrichton alexcrichton merged commit fd4b000 into rust-lang:master Jan 13, 2016
@hauleth hauleth deleted the from-str-oid branch January 13, 2016 22:38
@hauleth
Copy link
Contributor Author

hauleth commented Jan 13, 2016

I haven't removed Oid::from_str as it would need version bump. It should be marked as deprecated and removed ASAP.

@alexcrichton
Copy link
Member

Ah it's fine to stick around, there's no harm in both an inherent and a trait method

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants