Skip to content
This repository has been archived by the owner on May 23, 2024. It is now read-only.

add 5 rustdoc ices #1303

Merged
merged 1 commit into from
Jun 12, 2022
Merged

add 5 rustdoc ices #1303

merged 1 commit into from
Jun 12, 2022

Conversation

@JohnTitor
Copy link
Member

I'm not sure if we should track the 'not implemented yet' ICEs, i.e. 98002. Any reason to add here?

@matthiaskrgr
Copy link
Member Author

Any reason to not track it?
If it's an official test that reproduces a crash, that's double bad imo.

@JohnTitor
Copy link
Member

Why do you want to track it? We usually track ICEs not to overlook a fix and to add a regression test. But if a cause is just "not implemented yet", an implementation PR will add some tests. What action we should take then if that "ICE" is fixed? I don't think it makes much sense.

@matthiaskrgr
Copy link
Member Author

There could also be some refactoring that removes the panic, or the code leading to it accidentally, without any tests being added, which has already happened. Then we know that we can add the ice code as a test.

If the ice is fixed, we know we can close the ticket?

@JohnTitor
Copy link
Member

Fair enough 👍

@JohnTitor JohnTitor merged commit 8612cba into rust-lang:master Jun 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants