Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail to build on Windows #85

Closed
retep998 opened this issue Jul 23, 2019 · 4 comments · Fixed by #88
Closed

Tests fail to build on Windows #85

retep998 opened this issue Jul 23, 2019 · 4 comments · Fixed by #88

Comments

@retep998
Copy link
Member

   Compiling glob v0.3.0 (C:\crater\workdir)
error[E0432]: unresolved import `std::ffi::AsOsStr`
    --> src\lib.rs:1081:17
     |
1081 |             use std::ffi::AsOsStr;
     |                 ^^^^^^^^^^-------
     |                 |         |
     |                 |         help: a similar name exists in the module: `OsStr`
     |                 no `AsOsStr` in `ffi`

error[E0624]: method `prefix` is private
    --> src\lib.rs:1086:33
     |
1086 |                 .and_then(|p| p.prefix().map(|p| p.join("*")))
     |                                 ^^^^^^

error: aborting due to 2 previous errors
@KodrAus
Copy link
Contributor

KodrAus commented Jul 24, 2019

Oops... Thanks for the report @retep998!

I've reached out to see if we've got an Azure Pipelines plan we can use here in the nursery so we can check Windows in CI too.

@KodrAus
Copy link
Contributor

KodrAus commented Jul 25, 2019

Alrighty, we've got a Pipelines project created so I'll go set it up so we get CI for Windows running.

@KodrAus
Copy link
Contributor

KodrAus commented Jul 29, 2019

CI is now set up for Windows so if anybody would like to take a shot at getting these tests to compile on Windows they should be checked properly now going forward.

@SOF3
Copy link

SOF3 commented Aug 12, 2019

What is that prefix function even supposed to do?

The one in the Rust source code has a prefix() -> Prefix definition, but Prefix does not contain join either.

steveklabnik added a commit to steveklabnik/glob that referenced this issue Sep 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants