Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

highfive should not assign someone to their own PR #326

Closed
joshtriplett opened this issue Apr 16, 2021 · 3 comments
Closed

highfive should not assign someone to their own PR #326

joshtriplett opened this issue Apr 16, 2021 · 3 comments

Comments

@joshtriplett
Copy link
Member

In rust-lang/rust#84257 , rust-highfive assigned me to review my own PR.
@m-ou-se
Copy link
Member

m-ou-se commented Apr 19, 2021

That's weird. It specifically excludes the author of the PR here:

highfive/highfive/newpr.py

Line 306 in a2e3b19

reviewers.remove(exclude)

Which comes from the last argument here:

highfive/highfive/newpr.py

Lines 384 to 386 in a2e3b19

reviewer = self.choose_reviewer(
repo, owner, diff, author
)

Set here:

highfive/highfive/newpr.py

Line 369 in a2e3b19

author = self.payload['pull_request', 'user', 'login']

@m-ou-se
Copy link
Member

m-ou-se commented Apr 19, 2021 •
edited
Loading

Ah, the casing of your username in the high-five config doesn't match the one github uses: JoshTriplett vs joshtriplett

highfive/highfive/configs/rust-lang/rust.json

Line 16 in a2e3b19

"@JoshTriplett",

If you click [edit] on rust-lang/rust#84257 (comment), you can see the bot is using JoshTriplett and not joshtriplett (even though github shows the former as the latter).

image
image

@joshtriplett
Copy link
Member Author

@m-ou-se Ah, interesting. Ideally the bot should match ignoring case the same way GitHub does, but in the meantime, it sounds like the easiest fix would be to change my username in the configuration to all-lowercase.

joshtriplett added a commit to joshtriplett/highfive that referenced this issue Apr 20, 2021
@joshtriplett
Fix the case of my username so highfive doesn't assign me my own PRs
fbd7662 
Per the discusion at rust-lang#326 ,
this happened because highfive has me in the rotation as `JoshTriplett`,
but GitHub has my username as `joshtriplett`, and highfive checks for an
exact match including case.
@joshtriplett joshtriplett mentioned this issue Apr 20, 2021
Merged
CraftyDH added a commit to CraftyDH/highfive that referenced this issue Sep 3, 2021
@CraftyDH
use lower() to fix rust-lang#326
499c00c
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshtriplett @m-ou-se