-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mallopt #1071
Add mallopt #1071
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
So from the Travis failures it's evident this doesn't exist in musl. Is there a place for glibc-specific APIs? Or does that place it beyond the scope of this crate? EDIT: I've found the solution by looking through other PRs. |
I'm pretty sure the one failing config was caused by a docker image failing to build. Not sure where to go from here with that. |
@bors: r+ Looks great to me, thanks! |
📌 Commit a9590b5 has been approved by |
Add mallopt First time contributor. Thanks for the excellent contributing guide. I'm not quite sure I put the method in the right place. [The GNULib docs](https://www.gnu.org/software/gnulib/manual/html_node/mallopt.html) say its not on Android 7.1, but there are [mentions of it in some android headers](https://android.googlesource.com/platform/bionic/+/master/libc/include/malloc.h).
☀️ Test successful - status-appveyor, status-travis |
First time contributor. Thanks for the excellent contributing guide.
I'm not quite sure I put the method in the right place. The GNULib docs say its not on Android 7.1, but there are mentions of it in some android headers.