Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redox: convert to target_family unix #1332

Merged
merged 1 commit into from May 16, 2019

Conversation

@jackpot51
Copy link
Contributor

commented May 4, 2019

This is the first step to supporting rust-lang/rust#60139.

In order to have a smooth transition, there will need to be a change made in rust at the same time, switching Redox over to the unix target family. See rust-lang/rust#60547

@rust-highfive

This comment has been minimized.

Copy link

commented May 4, 2019

r? @gnzlbg

(rust_highfive has picked a reviewer for you, use r? to override)

@jackpot51 jackpot51 force-pushed the redox-os:redox-unix branch from 901a0f5 to eb75c48 May 4, 2019

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2019

@jackpot51 I think it would be better to make the rust-lang/rust PR use the libc of this branch, and once bors try passes there, then we can merge this here, release, and update the rust-lang/rust PR to use the released version, and merge it with high priority. What do you think?

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

I think that sounds good to me. I will do that soon

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

commented May 6, 2019

@jackpot51 jackpot51 marked this pull request as ready for review May 8, 2019

bors added a commit to rust-lang/rust that referenced this pull request May 8, 2019
Auto merge of #60547 - redox-os:redox-unix, r=<try>
redox: convert to target_family unix

This is the second step to supporting #60139.

In order to have a smooth transition, there will need to be a change made in liblibc at the same time, switching Redox over to the unix target family. See rust-lang/libc#1332
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

commented May 10, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

📌 Commit eb75c48 has been approved by gnzlbg

@bors

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

⌛️ Testing commit eb75c48 with merge 1d01758...

bors added a commit that referenced this pull request May 10, 2019
Auto merge of #1332 - redox-os:redox-unix, r=gnzlbg
redox: convert to target_family unix

This is the first step to supporting rust-lang/rust#60139.

In order to have a smooth transition, there will need to be a change made in rust at the same time, switching Redox over to the unix target family. See rust-lang/rust#60547
@gnzlbg

This comment has been minimized.

Copy link
Collaborator

commented May 10, 2019

So let's merge this, do a release, and then you can update the PR upstream !

@bors

This comment has been minimized.

Copy link
Contributor

commented May 10, 2019

💔 Test failed - checks-travis

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

commented May 11, 2019

@gnzlbg what should I do about the build failure? I checked and the failures do not seem to be introduced by this PR, but am open to including fixes if possible and necessary.

@mati865

This comment has been minimized.

Copy link
Contributor

commented May 11, 2019

It's #1333

The thing is upgrading system on CI is not trivial task for this repo because the code is verified against the system.

@gnzlbg

This comment has been minimized.

Copy link
Collaborator

commented May 16, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

📌 Commit eb75c48 has been approved by gnzlbg

bors added a commit that referenced this pull request May 16, 2019
Auto merge of #1332 - redox-os:redox-unix, r=gnzlbg
redox: convert to target_family unix

This is the first step to supporting rust-lang/rust#60139.

In order to have a smooth transition, there will need to be a change made in rust at the same time, switching Redox over to the unix target family. See rust-lang/rust#60547
@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

⌛️ Testing commit eb75c48 with merge 5408b10...

@bors

This comment has been minimized.

Copy link
Contributor

commented May 16, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing 5408b10 to master...

@bors bors merged commit eb75c48 into rust-lang:master May 16, 2019

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
stable x86_64-unknown-freebsd Task Summary
Details
@jackpot51

This comment has been minimized.

Copy link
Contributor Author

commented May 16, 2019

Woohoo!

bors added a commit to rust-lang/rust that referenced this pull request May 18, 2019
Auto merge of #60547 - redox-os:redox-unix, r=alexcrichton
redox: convert to target_family unix

This is the second step to supporting #60139.

In order to have a smooth transition, there will need to be a change made in liblibc at the same time, switching Redox over to the unix target family. See rust-lang/libc#1332
@newpavlov newpavlov referenced this pull request Jul 30, 2019
bors added a commit to rust-lang/rust that referenced this pull request Aug 7, 2019
Auto merge of #60547 - redox-os:redox-unix, r=alexcrichton
redox: convert to target_family unix

This is the second step to supporting #60139.

In order to have a smooth transition, there will need to be a change made in liblibc at the same time, switching Redox over to the unix target family. See rust-lang/libc#1332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.