Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redox: convert to target_family unix #60547

Merged
merged 2 commits into from Aug 7, 2019
Merged

redox: convert to target_family unix #60547

merged 2 commits into from Aug 7, 2019

Conversation

@jackpot51
Copy link
Contributor

jackpot51 commented May 4, 2019

This is the second step to supporting #60139.

In order to have a smooth transition, there will need to be a change made in liblibc at the same time, switching Redox over to the unix target family. See rust-lang/libc#1332

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 4, 2019

r? @shepmaster

(rust_highfive has picked a reviewer for you, use r? to override)

@Centril

This comment has been minimized.

Copy link
Member

Centril commented May 5, 2019

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 6, 2019

@gnzlbg I have replaced libc with the version that needs to pair with this PR in this commit: 2ab50af

@gnzlbg

This comment has been minimized.

Copy link
Contributor

gnzlbg commented May 6, 2019

So once try is green here, we can merge the libc PR upstream, and update rust-lang/rust libc.

IIRC, tidy does not like cargo dependencies to git, so one might need to temporarily disable that for this to pass.

Copy link
Member

alexcrichton left a comment

Looks reasonable to me! I don't have an opinion one way or another on what target_family it's considered under, but for the existing sys/unix code the primary goal I think is to absolute reduce the amount of #[cfg] as much as possible. It's needed in some cases for sure, but each additional #[cfg] tends to add more complexity we have to manage in the future...

src/libstd/sys/unix/process/process_unix.rs Outdated Show resolved Hide resolved
src/libstd/sys/unix/os.rs Outdated Show resolved Hide resolved
src/libstd/path.rs Outdated Show resolved Hide resolved
@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 6, 2019

@gnzlbg @mati865 @alexcrichton thanks for the review, I will be updating to address your comments soon

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 6, 2019

It has been a pretty long time that we have had to carry a forked version of Rust along with a complicated build process in the Redox repository due to this one change (#52331) not being present in upstream. What is the best way to move forward on it?

I am open to anything that would make a path like "file:/home" parse into components like this:

Prefix("file:")
RootDir
Normal("home")

It can require a feature flag to match on the Redox-specific prefix and only be available on Redox, whatever it takes to make checks for a prefix return true.

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented May 6, 2019

The fact that Windows-specific API components leaked into the cross-platform public part of the path API is basically a mistake in the standard library and something we shouldn't have done at 1.0. What should in theory have happened instead was to have platform-specific extension traits for Windows to access the various pieces, paving a path for Redox as well to have platform-specific extensions of Path.

The solution proposed on that issue sounds like it would work quite well, and we could discuss in the libs team as well if we want to be more aggressive about deprecation warnings to change the Windows idioms there as well.

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 6, 2019

For now, I will remove the Prefix change. I hope I can address it in a way everyone is happy with soon.

@jackpot51 jackpot51 marked this pull request as ready for review May 6, 2019
@jackpot51 jackpot51 force-pushed the redox-os:redox-unix branch from ab51ab0 to 63bf956 May 6, 2019
@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 6, 2019

Ok, the comments from @alexcrichton and @mati865 should now be addressed. I also rebased on master.

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 6, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0516e6f0:start=1557176987072050363,finish=1557176989299577100,duration=2227526737
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
######################################################################## 100.0%
[00:01:52] extracting /checkout/obj/build/cache/2019-04-11/cargo-beta-x86_64-unknown-linux-gnu.tar.gz
[00:01:52]     Updating git repository `https://github.com/redox-os/liblibc.git`
[00:01:54]     Updating crates.io index
[00:02:10] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:10] Build completed unsuccessfully in 0:00:32
[00:02:10] make: *** [prepare] Error 1
[00:02:10] Makefile:69: recipe for target 'prepare' failed
[00:02:11] Command failed. Attempt 2/5:
[00:02:11] Command failed. Attempt 2/5:
[00:02:12] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:12] Build completed unsuccessfully in 0:00:00
[00:02:12] make: *** [prepare] Error 1
[00:02:12] Makefile:69: recipe for target 'prepare' failed
[00:02:14] Command failed. Attempt 3/5:
[00:02:14] Command failed. Attempt 3/5:
[00:02:14] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:14] Build completed unsuccessfully in 0:00:00
[00:02:14] make: *** [prepare] Error 1
[00:02:14] Makefile:69: recipe for target 'prepare' failed
[00:02:17] Command failed. Attempt 4/5:
[00:02:17] Command failed. Attempt 4/5:
[00:02:18] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:18] Build completed unsuccessfully in 0:00:00
[00:02:18] make: *** [prepare] Error 1
[00:02:18] Makefile:69: recipe for target 'prepare' failed
[00:02:22] Command failed. Attempt 5/5:
[00:02:22] Command failed. Attempt 5/5:
[00:02:22] error: the lock file /checkout/Cargo.lock needs to be updated but --locked was passed to prevent this
[00:02:22] Build completed unsuccessfully in 0:00:00
[00:02:22] Makefile:69: recipe for target 'prepare' failed
[00:02:22] make: *** [prepare] Error 1
[00:02:22] The command has failed after 5 attempts.
---
travis_time:end:295e3f06:start=1557177143230315399,finish=1557177143235065182,duration=4749783
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:2399a160
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:2ac572d6
travis_time:start:2ac572d6
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:13c1cf40
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 6, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:13558368:start=1557177349819951465,finish=1557177352264822990,duration=2444871525
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:02:15]    Compiling proc-macro2 v0.4.24
[00:02:15]    Compiling unicode-xid v0.1.0
[00:02:15]    Compiling serde v1.0.82
[00:02:15]    Compiling ryu v0.2.7
[00:02:15]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:02:15]    Compiling cfg-if v0.1.6
[00:02:15]    Compiling ordermap v0.3.5
[00:02:15]    Compiling itoa v0.4.3
[00:02:15]    Compiling cc v1.0.35
---

[00:04:23] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:24] tidy error: /checkout/src/libstd/sys/unix/rand.rs:181: trailing whitespace
[00:04:24] tidy error: /checkout/src/libstd/sys/unix/process/process_unix.rs:192: TODO is deprecated; use FIXME
[00:04:28] tidy error: The Unstable Book has a 'library feature' section 'n16' which doesn't correspond to an unstable library feature
[00:04:29] invalid source: "git+https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489172e10bfcb57ca679ff337827cf783a9"
[00:04:29] some tidy checks failed
[00:04:29] 
[00:04:29] 
[00:04:29] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:29] 
[00:04:29] 
[00:04:29] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:29] Build completed unsuccessfully in 0:01:07
[00:04:29] Build completed unsuccessfully in 0:01:07
[00:04:29] Makefile:67: recipe for target 'tidy' failed
[00:04:29] make: *** [tidy] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:21996447
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Mon May  6 21:20:32 UTC 2019
---
travis_time:end:03e801c4:start=1557177633345809229,finish=1557177633350301411,duration=4492182
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:01acad3e
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:06d8bdea
travis_time:start:06d8bdea
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0b6bf134
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 7, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:2f0d5dc2:start=1557192507740566299,finish=1557192510485496203,duration=2744929904
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:02:27]   Downloaded ryu v0.2.7
[00:02:27]    Compiling proc-macro2 v0.4.24
[00:02:27]    Compiling unicode-xid v0.1.0
[00:02:27]    Compiling ryu v0.2.7
[00:02:27]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:02:28]    Compiling itoa v0.4.3
[00:02:28]    Compiling ordermap v0.3.5
[00:02:28]    Compiling cc v1.0.35
[00:02:28]    Compiling cfg-if v0.1.6
---
travis_time:start:stage0-std
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:03:36]    Compiling cc v1.0.35
[00:03:36]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:03:36]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:03:37]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:03:42]    Compiling compiler_builtins v0.1.10
[00:03:42]    Compiling cmake v0.1.38
[00:03:42]    Compiling backtrace-sys v0.1.27
---
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:04:52]    Compiling semver-parser v0.7.0
[00:04:52]    Compiling nodrop v0.1.12
[00:04:52]    Compiling cfg-if v0.1.6
[00:04:52]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:04:53]    Compiling rand_core v0.3.0
[00:04:53]    Compiling void v1.0.2
[00:04:53]    Compiling proc-macro2 v0.4.24
[00:04:53]    Compiling scopeguard v0.3.3
---
[00:24:45] travis_time:end:stage0-rustc:start=1557192816313526218,finish=1557194009452501155,duration=1193138974937

[00:24:45] Building stage0 codegen artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu, llvm)
[00:24:45]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:24:45]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:24:45]    Compiling rustc_codegen_llvm v0.0.0 (/checkout/src/librustc_codegen_llvm)
[00:24:46]    Compiling rustc-demangle v0.1.10
[00:24:53]    Compiling num_cpus v1.8.0
[00:24:53]    Compiling memmap v0.6.2
---
travis_time:start:stage1-std
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:26:09]    Compiling cc v1.0.35
[00:26:09]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:26:09]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:26:09]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:26:15]    Compiling compiler_builtins v0.1.10
[00:26:15]    Compiling cmake v0.1.38
[00:26:15]    Compiling backtrace-sys v0.1.27
---
travis_time:start:stage1-rustc
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:27:45]    Compiling semver-parser v0.7.0
[00:27:45]    Compiling cfg-if v0.1.6
[00:27:45]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:27:45]    Compiling void v1.0.2
[00:27:46]    Compiling memoffset v0.2.1
[00:27:46]    Compiling rand_core v0.3.0
[00:27:46]    Compiling scopeguard v0.3.3
---

[00:52:36] Building stage1 codegen artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu, llvm)
[00:52:37]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:52:37]    Compiling cc v1.0.35
[00:52:37]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:52:38]    Compiling rustc-demangle v0.1.10
[00:52:47]    Compiling rustc_llvm v0.0.0 (/checkout/src/librustc_llvm)
[00:52:49]    Compiling memmap v0.6.2
[00:52:49]    Compiling num_cpus v1.8.0
---
[00:54:17] travis_fold:start:stage2-rustdoc
travis_time:start:stage2-rustdoc
Building rustdoc for stage2 (x86_64-unknown-linux-gnu)
[00:54:18]    Compiling semver-parser v0.7.0
[00:54:18]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:54:18]    Compiling void v1.0.2
[00:54:18]    Compiling version_check v0.1.5
[00:54:19]    Compiling memchr v2.2.0
[00:54:19]    Compiling stable_deref_trait v1.1.0
---

[00:58:11] travis_fold:start:stage0-rustbook
travis_time:start:stage0-rustbook
Building stage0 tool rustbook (x86_64-unknown-linux-gnu)
[00:58:11]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:58:11]    Compiling string_cache_shared v0.3.0
[00:58:11]    Compiling semver-parser v0.7.0
[00:58:11]    Compiling cc v1.0.35
[00:58:12]    Compiling void v1.0.2
---
[01:02:33] travis_fold:start:stage1-rustdoc
travis_time:start:stage1-rustdoc
Building rustdoc for stage1 (x86_64-unknown-linux-gnu)
[01:02:34]    Compiling semver-parser v0.7.0
[01:02:34]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[01:02:34]    Compiling rand_core v0.3.0
[01:02:34]    Compiling version_check v0.1.5
[01:02:35]    Compiling memchr v2.2.0
[01:02:35]    Compiling stable_deref_trait v1.1.0
---
[01:05:13]  Documenting alloc v0.0.0 (/checkout/src/liballoc)
[01:05:17]     Finished release [optimized] target(s) in 37.24s
[01:05:18]  Documenting core v0.0.0 (/checkout/src/libcore)
[01:05:43]     Finished release [optimized] target(s) in 25.31s
[01:05:44]     Checking libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[01:05:44]     Checking alloc v0.0.0 (/checkout/src/liballoc)
[01:05:44]     Checking rustc-demangle v0.1.10
[01:05:45]     Checking unwind v0.0.0 (/checkout/src/libunwind)
[01:05:45]     Checking backtrace-sys v0.1.27
---
[01:06:25] travis_fold:start:stage2-error_index_generator
travis_time:start:stage2-error_index_generator
Building stage2 tool error_index_generator (x86_64-unknown-linux-gnu)
[01:06:26]    Compiling semver-parser v0.7.0
[01:06:26]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[01:06:26]    Compiling rand_core v0.3.0
[01:06:27]    Compiling void v1.0.2
[01:06:27]    Compiling memchr v2.2.0
[01:06:28]    Compiling stable_deref_trait v1.1.0
---

[01:09:17] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[01:09:17] tidy error: /checkout/src/libstd/sys/unix/rand.rs:181: trailing whitespace
[01:09:17] tidy error: /checkout/src/libstd/sys/unix/process/process_unix.rs:192: TODO is deprecated; use FIXME
[01:09:22] tidy error: The Unstable Book has a 'library feature' section 'n16' which doesn't correspond to an unstable library feature
[01:09:22] invalid source: "git+https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489172e10bfcb57ca679ff337827cf783a9"
[01:09:22] some tidy checks failed
[01:09:22] 
[01:09:22] 
[01:09:22] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[01:09:22] 
[01:09:22] 
[01:09:22] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:09:22] Build completed unsuccessfully in 0:00:08
[01:09:22] Build completed unsuccessfully in 0:00:08
[01:09:22] Makefile:48: recipe for target 'check' failed
[01:09:22] make: *** [check] Error 1
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:010b74d9
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Tue May  7 02:38:07 UTC 2019
---
travis_time:end:0086ea9e:start=1557196688755112459,finish=1557196688760260562,duration=5148103
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:3671c6ed
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:204ad4ff
travis_time:start:204ad4ff
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:35314ff0
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jackpot51 jackpot51 force-pushed the redox-os:redox-unix branch from f9acbc7 to 0b9fcf5 May 7, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:15c6e2d8:start=1557273005422692049,finish=1557273093284164653,duration=87861472604
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:01:48]    Compiling proc-macro2 v0.4.24
[00:01:48]    Compiling unicode-xid v0.1.0
[00:01:48]    Compiling serde v1.0.82
[00:01:48]    Compiling ryu v0.2.7
[00:01:48]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:01:48]    Compiling cc v1.0.35
[00:01:48]    Compiling cfg-if v0.1.6
[00:01:49]    Compiling itoa v0.4.3
[00:01:49]    Compiling unicode-width v0.1.5
---
travis_time:start:stage0-std
Building stage0 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:02:55]    Compiling cc v1.0.35
[00:02:55]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:02:55]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:02:56]    Compiling unwind v0.0.0 (/checkout/src/libunwind)
[00:03:01]    Compiling compiler_builtins v0.1.10
[00:03:01]    Compiling cmake v0.1.38
[00:03:01]    Compiling backtrace-sys v0.1.27
---
travis_time:start:stage0-rustc
Building stage0 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:04:14]    Compiling semver-parser v0.7.0
[00:04:14]    Compiling nodrop v0.1.12
[00:04:14]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:04:14]    Compiling proc-macro2 v0.4.24
[00:04:14]    Compiling lazy_static v1.2.0
[00:04:15]    Compiling scopeguard v0.3.3
[00:04:15]    Compiling rand_core v0.3.0
---

[00:24:39] Building stage0 codegen artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu, llvm)
[00:24:40]    Compiling cc v1.0.35
[00:24:40]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:24:40]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:24:41]    Compiling rustc-demangle v0.1.10
[00:24:48]    Compiling rustc_llvm v0.0.0 (/checkout/src/librustc_llvm)
[00:24:49]    Compiling memmap v0.6.2
[00:24:49]    Compiling num_cpus v1.8.0
---
travis_time:start:stage1-std
Building stage1 std artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:26:06]    Compiling cc v1.0.35
[00:26:06]    Compiling core v0.0.0 (/checkout/src/libcore)
[00:26:06]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:26:06]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:26:12]    Compiling compiler_builtins v0.1.10
[00:26:12]    Compiling cmake v0.1.38
[00:26:12]    Compiling backtrace-sys v0.1.27
---
Building stage1 compiler artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[00:27:47]    Compiling semver-parser v0.7.0
[00:27:47]    Compiling nodrop v0.1.12
[00:27:47]    Compiling cfg-if v0.1.6
[00:27:47]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:27:48]    Compiling rand_core v0.3.0
[00:27:48]    Compiling memoffset v0.2.1
[00:27:48]    Compiling void v1.0.2
[00:27:48]    Compiling proc-macro2 v0.4.24
---
[00:53:05] travis_time:end:stage1-rustc:start=1557274769133720657,finish=1557276287332770914,duration=1518199050257

[00:53:05] Building stage1 codegen artifacts (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu, llvm)
[00:53:05]    Compiling build_helper v0.1.0 (/checkout/src/build_helper)
[00:53:05]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:53:05]    Compiling rustc_codegen_llvm v0.0.0 (/checkout/src/librustc_codegen_llvm)
[00:53:07]    Compiling rustc-demangle v0.1.10
[00:53:15]    Compiling num_cpus v1.8.0
[00:53:18]    Compiling memmap v0.6.2
---
[00:54:49] travis_fold:start:stage2-rustdoc
travis_time:start:stage2-rustdoc
Building rustdoc for stage2 (x86_64-unknown-linux-gnu)
[00:54:49]    Compiling semver-parser v0.7.0
[00:54:49]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:54:49]    Compiling rand_core v0.3.0
[00:54:49]    Compiling version_check v0.1.5
[00:54:51]    Compiling memchr v2.2.0
[00:54:51]    Compiling stable_deref_trait v1.1.0
---
[00:57:52]    Compiling syn v0.15.22
[00:57:57]    Compiling serde_json v1.0.33
[00:58:11]    Compiling serde_derive v1.0.81
[00:58:32]    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
[00:58:33] error: unused variable: `source`
[00:58:33]   --> src/tools/tidy/src/extdeps.rs:27:13
[00:58:33]    |
[00:58:33] 27 |         let source = line.splitn(2, '=').nth(1).unwrap().trim();
[00:58:33]    |             ^^^^^^ help: consider prefixing with an underscore: `_source`
[00:58:33]    = note: `-D unused-variables` implied by `-D warnings`
[00:58:33] 
[00:58:33] error: unused variable: `bad`
[00:58:33] error: unused variable: `bad`
[00:58:33]   --> src/tools/tidy/src/extdeps.rs:12:27
[00:58:33]    |
[00:58:33] 12 | pub fn check(path: &Path, bad: &mut bool) {
[00:58:33]    |                           ^^^ help: consider prefixing with an underscore: `_bad`
[00:58:33] error: aborting due to 2 previous errors
[00:58:33] 
[00:58:33] 
[00:58:33] error: Could not compile `tidy`.
[00:58:33] To learn more, run the command again with --verbose.
[00:58:33] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/unstable-book-gen/Cargo.toml" "--message-format" "json"
[00:58:33] expected success, got: exit code: 101
[00:58:33] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
---
travis_time:end:041f71ba:start=1557276616828939446,finish=1557276616833863840,duration=4924394
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:018268d4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:077218a4
travis_time:start:077218a4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:00091b09
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jackpot51 jackpot51 force-pushed the redox-os:redox-unix branch from 0b9fcf5 to 60b6e7f May 8, 2019
@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented May 8, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:0f5e86ba:start=1557280517335648013,finish=1557280603654443197,duration=86318795184
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:01:47]   Downloaded unicode-xid v0.1.0
[00:01:47]    Compiling proc-macro2 v0.4.24
[00:01:47]    Compiling unicode-xid v0.1.0
[00:01:47]    Compiling serde v1.0.82
[00:01:47]    Compiling libc v0.2.54 (https://github.com/redox-os/liblibc.git?branch=redox-unix#eb75c489)
[00:01:48]    Compiling unicode-width v0.1.5
[00:01:48]    Compiling ordermap v0.3.5
[00:01:48]    Compiling fixedbitset v0.1.9
[00:01:48]    Compiling itoa v0.4.3
---
[00:03:08]    Compiling syn v0.15.22
[00:03:14]    Compiling serde_json v1.0.33
[00:03:27]    Compiling serde_derive v1.0.81
[00:03:47]    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
[00:03:48] error: constant item is never used: `WHITELISTED_SOURCES`
[00:03:48]  --> src/tools/tidy/src/extdeps.rs:7:1
[00:03:48] 7 | / const WHITELISTED_SOURCES: &[&str] = &[
[00:03:48] 7 | / const WHITELISTED_SOURCES: &[&str] = &[
[00:03:48] 8 | |     "\"registry+https://github.com/rust-lang/crates.io-index\"",
[00:03:48] 9 | | ];
[00:03:48]   |
[00:03:48]   = note: `-D dead-code` implied by `-D warnings`
[00:03:48] 
[00:03:48] error: aborting due to previous error
[00:03:48] error: aborting due to previous error
[00:03:48] 
[00:03:48] error: Could not compile `tidy`.
[00:03:48] To learn more, run the command again with --verbose.
[00:03:48] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--manifest-path" "/checkout/src/tools/tidy/Cargo.toml" "--message-format" "json"
[00:03:48] expected success, got: exit code: 101
[00:03:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:48] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:03:48] Build completed unsuccessfully in 0:00:54
[00:03:48] make: *** [tidy] Error 1
[00:03:48] Makefile:67: recipe for target 'tidy' failed
The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:11b1a006
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
Wed May  8 02:00:41 UTC 2019
---
travis_time:end:0154e54c:start=1557280842055524805,finish=1557280842060728761,duration=5203956
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0254ced5
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:1c54cdc0
travis_time:start:1c54cdc0
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:0137055c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@jackpot51 jackpot51 force-pushed the redox-os:redox-unix branch 2 times, most recently from 8850362 to 46eddf7 May 8, 2019
@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 8, 2019

I got the build mostly under control. The last error was this:

tidy error: The Unstable Book has a 'library feature' section 'n16' which doesn't correspond to an unstable library feature

Which does not appear to be caused by any changes I made

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented May 8, 2019

Ok @gnzlbg, it builds for Linux at least. I have rebased everything so I can revert to only the first commit when the libc patch lands

@gnzlbg

This comment has been minimized.

Copy link
Contributor

gnzlbg commented May 8, 2019

@bors: try

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Jun 25, 2019

☔️ The latest upstream changes (presumably #62100) made this pull request unmergeable. Please resolve the merge conflicts.

@mati865 mati865 mentioned this pull request Jul 7, 2019
@joelpalmer

This comment has been minimized.

Copy link

joelpalmer commented Jul 22, 2019

Hi @jackpot51 - this is a ping from Triage. Please send an update on this PR at your earliest convenience.

@mati865

This comment has been minimized.

Copy link
Contributor

mati865 commented Jul 22, 2019

There is no point in rebasing this PR over and over while it's still blocked on #61393

@rustbot modify labels: -S-waiting-on-author +S-blocked

@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented Jul 22, 2019

@joelpalmer, this is still waiting on #61393. I will rebase when that or something similar is merged

@jackpot51 jackpot51 mentioned this pull request Jul 30, 2019
@mati865

This comment has been minimized.

Copy link
Contributor

mati865 commented Aug 2, 2019

#61393 was merged

@rustbot modify labels: -S-blocked +S-waiting-on-author

@jackpot51 jackpot51 force-pushed the redox-os:redox-unix branch from 08f2d71 to 0498da9 Aug 6, 2019
@jackpot51

This comment has been minimized.

Copy link
Contributor Author

jackpot51 commented Aug 6, 2019

I have rebased this PR, waiting on review from @alexcrichton

@rust-highfive

This comment has been minimized.

Copy link
Collaborator

rust-highfive commented Aug 7, 2019

The job x86_64-gnu-llvm-6.0 of your PR failed (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-08-06T22:25:00.4579963Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-08-06T22:25:00.4779206Z ##[command]git config gc.auto 0
2019-08-06T22:25:00.4855597Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-08-06T22:25:00.4940690Z ##[command]git config --get-all http.proxy
2019-08-06T22:25:00.5073448Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/60547/merge:refs/remotes/pull/60547/merge
---
2019-08-06T22:25:37.4794777Z do so (now or later) by using -b with the checkout command again. Example:
2019-08-06T22:25:37.4794811Z 
2019-08-06T22:25:37.4795044Z   git checkout -b <new-branch-name>
2019-08-06T22:25:37.4795259Z 
2019-08-06T22:25:37.4795336Z HEAD is now at f1690e3e4 Merge 0498da9a3dc061f604fcfb9b56bd889e07f2b7e2 into 6a91782b72fca586b15ba68364bc7baab837af86
2019-08-06T22:25:37.4984366Z ##[section]Starting: Collect CPU-usage statistics in the background
2019-08-06T22:25:37.4987527Z ==============================================================================
2019-08-06T22:25:37.4987592Z Task         : Bash
2019-08-06T22:25:37.4987645Z Description  : Run a Bash script on macOS, Linux, or Windows
---
2019-08-06T23:28:42.9276559Z .................................................................................................... 1400/8833
2019-08-06T23:28:49.1664254Z .................................................................................................... 1500/8833
2019-08-06T23:29:01.7677555Z .........................................................................i...............i.......... 1600/8833
2019-08-06T23:29:09.2730264Z .................................................................................................... 1700/8833
2019-08-06T23:29:24.8566296Z ...........................................................iiiii.................................... 1800/8833
2019-08-06T23:29:37.4341729Z .................................................................................................... 2000/8833
2019-08-06T23:29:40.0930840Z .................................................................................................... 2100/8833
2019-08-06T23:29:43.4264528Z .................................................................................................... 2200/8833
2019-08-06T23:29:51.3934792Z .................................................................................................... 2300/8833
---
2019-08-06T23:33:45.7823806Z .................................................................................................... 5200/8833
2019-08-06T23:33:56.6503714Z ...........................................................................i........................ 5300/8833
2019-08-06T23:34:04.4314788Z .................................................................................................... 5400/8833
2019-08-06T23:34:11.1089509Z .................................................................................................... 5500/8833
2019-08-06T23:34:22.8678862Z .....................................................................ii...i..ii...........i......... 5600/8833
2019-08-06T23:34:44.5904537Z .................................................................................................... 5800/8833
2019-08-06T23:34:49.8950417Z .................................................................................................... 5900/8833
2019-08-06T23:34:49.8950417Z .................................................................................................... 5900/8833
2019-08-06T23:34:55.8665790Z ......................................................................i..ii......................... 6000/8833
2019-08-06T23:35:26.3050805Z .................................................................................................... 6200/8833
2019-08-06T23:35:28.5196849Z .............i...................................................................................... 6300/8833
2019-08-06T23:35:30.7426688Z .....................................................................................i.............. 6400/8833
2019-08-06T23:35:33.5581978Z .................................................................................................... 6500/8833
---
2019-08-06T23:40:29.5337816Z  finished in 23.122
2019-08-06T23:40:29.5554588Z Check compiletest suite=codegen mode=codegen (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-06T23:40:30.1782213Z 
2019-08-06T23:40:30.1843624Z running 146 tests
2019-08-06T23:40:33.2674762Z i....iii......iii..iiii....i............................i..i................i....i.........ii.i.i..i 100/146
2019-08-06T23:40:35.2039831Z iii..............i.........iii.i......ii......
2019-08-06T23:40:35.2040360Z 
2019-08-06T23:40:35.2046606Z  finished in 5.649
2019-08-06T23:40:35.2237380Z Check compiletest suite=codegen-units mode=codegen-units (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-06T23:40:35.3801669Z 
---
2019-08-06T23:40:38.1800819Z  finished in 2.336
2019-08-06T23:40:38.1801199Z Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-06T23:40:38.1801234Z 
2019-08-06T23:40:38.1801288Z running 9 tests
2019-08-06T23:40:38.1801543Z iiiiiiiii
2019-08-06T23:40:38.1801823Z 
2019-08-06T23:40:38.1801858Z  finished in 0.151
2019-08-06T23:40:38.1802107Z Check compiletest suite=incremental mode=incremental (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-06T23:40:38.1802359Z 
---
2019-08-06T23:40:56.8562468Z  finished in 19.107
2019-08-06T23:40:56.8791237Z Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-06T23:40:57.0560768Z 
2019-08-06T23:40:57.0562759Z running 122 tests
2019-08-06T23:41:22.0828559Z .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
2019-08-06T23:41:27.0960685Z .i.i......iii.i.....ii
2019-08-06T23:41:27.0961836Z 
2019-08-06T23:41:27.0968080Z  finished in 30.218
2019-08-06T23:41:27.0977380Z Uplifting stage1 rustc (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-06T23:41:27.0978088Z Copying stage2 rustc from stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu / x86_64-unknown-linux-gnu)
---
2019-08-06T23:56:19.8889130Z 
2019-08-06T23:56:19.8891462Z    Doc-tests core
2019-08-06T23:56:24.4173443Z 
2019-08-06T23:56:24.4174466Z running 2379 tests
2019-08-06T23:56:37.7709931Z ......iiiii......................................................................................... 100/2379
2019-08-06T23:56:51.2277814Z .........................................................................ii......................... 200/2379
2019-08-06T23:57:22.7473503Z .................................................................................................... 400/2379
2019-08-06T23:57:22.7473503Z .................................................................................................... 400/2379
2019-08-06T23:57:34.8908089Z ..............................i..i.................iiii............................................. 500/2379
2019-08-06T23:58:00.2666366Z .................................................................................................... 700/2379
2019-08-06T23:58:13.2790675Z .................................................................................................... 800/2379
2019-08-06T23:58:26.3294693Z .................................................................................................... 900/2379
2019-08-06T23:58:39.3868450Z .................................................................................................... 1000/2379
---
2019-08-07T00:01:49.6606224Z 
2019-08-07T00:01:49.6661142Z  finished in 0.253
2019-08-07T00:01:49.6678277Z Testing std stage1 (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
2019-08-07T00:01:49.9161511Z    Compiling std v0.0.0 (/checkout/src/libstd)
2019-08-07T00:01:52.1836794Z error: cannot find macro `cfg_if!` in this scope
2019-08-07T00:01:52.1837948Z   --> src/libstd/sys/unix/os.rs:28:1
2019-08-07T00:01:52.1838867Z    |
2019-08-07T00:01:52.1840139Z 28 | cfg_if! {
2019-08-07T00:01:52.1840586Z 
2019-08-07T00:01:52.1840586Z 
2019-08-07T00:01:52.2866541Z error: cannot find macro `cfg_if!` in this scope
2019-08-07T00:01:52.2866974Z   --> src/libstd/sys/unix/process/process_common.rs:15:1
2019-08-07T00:01:52.2867297Z    |
2019-08-07T00:01:52.2867588Z 15 | cfg_if! {
2019-08-07T00:01:52.2867914Z 
2019-08-07T00:01:52.2867914Z 
2019-08-07T00:01:52.3673383Z error[E0425]: cannot find value `PATH_SEPARATOR` in this scope
2019-08-07T00:01:52.3673797Z    --> src/libstd/sys/unix/os.rs:166:45
2019-08-07T00:01:52.3674121Z     |
2019-08-07T00:01:52.3674492Z 166 |     fn is_separator(b: &u8) -> bool { *b == PATH_SEPARATOR }
2019-08-07T00:01:52.3674981Z 
2019-08-07T00:01:52.3674981Z 
2019-08-07T00:01:52.3909977Z error[E0425]: cannot find value `PATH_SEPARATOR` in this scope
2019-08-07T00:01:52.3911279Z    --> src/libstd/sys/unix/os.rs:190:32
2019-08-07T00:01:52.3911922Z     |
2019-08-07T00:01:52.3912586Z 190 |         if i > 0 { joined.push(PATH_SEPARATOR) }
2019-08-07T00:01:52.3914205Z 
2019-08-07T00:01:52.3914205Z 
2019-08-07T00:01:52.4141935Z error[E0425]: cannot find value `PATH_SEPARATOR` in this scope
2019-08-07T00:01:52.4143229Z    --> src/libstd/sys/unix/os.rs:191:27
2019-08-07T00:01:52.4143906Z     |
2019-08-07T00:01:52.4144612Z 191 |         if path.contains(&PATH_SEPARATOR) {
2019-08-07T00:01:52.4151537Z 
2019-08-07T00:01:52.4151537Z 
2019-08-07T00:01:52.4375669Z error[E0425]: cannot find value `PATH_SEPARATOR` in this scope
2019-08-07T00:01:52.4376084Z    --> src/libstd/sys/unix/os.rs:201:59
2019-08-07T00:01:52.4376481Z     |
2019-08-07T00:01:52.4376915Z 201 |         write!(f, "path segment contains separator `{}`", PATH_SEPARATOR)
2019-08-07T00:01:52.4377386Z 
2019-08-07T00:01:52.4377386Z 
2019-08-07T00:01:52.4608338Z error[E0425]: cannot find value `DEV_NULL` in this scope
2019-08-07T00:01:52.4608761Z    --> src/libstd/sys/unix/process/process_common.rs:309:36
2019-08-07T00:01:52.4609019Z     |
2019-08-07T00:01:52.4609391Z 309 |                     CStr::from_ptr(DEV_NULL.as_ptr() as *const _)
2019-08-07T00:01:52.4610200Z 
2019-08-07T00:02:06.9472684Z error: aborting due to 7 previous errors
2019-08-07T00:02:06.9473872Z 
2019-08-07T00:02:06.9474765Z For more information about this error, try `rustc --explain E0425`.
2019-08-07T00:02:06.9474765Z For more information about this error, try `rustc --explain E0425`.
2019-08-07T00:02:07.1058672Z error: Could not compile `std`.
2019-08-07T00:02:07.1059411Z 
2019-08-07T00:02:07.1059824Z To learn more, run the command again with --verbose.
2019-08-07T00:02:07.1073372Z 
2019-08-07T00:02:07.1073713Z 
2019-08-07T00:02:07.1085897Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "2" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "std" "--" "--quiet"
2019-08-07T00:02:07.1086093Z 
2019-08-07T00:02:07.1086126Z 
2019-08-07T00:02:07.1092192Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2019-08-07T00:02:07.1092297Z Build completed unsuccessfully in 1:30:06
2019-08-07T00:02:07.1092297Z Build completed unsuccessfully in 1:30:06
2019-08-07T00:02:07.6060991Z ##[error]Bash exited with code '1'.
2019-08-07T00:02:07.6112750Z ##[section]Starting: Checkout
2019-08-07T00:02:07.6115540Z ==============================================================================
2019-08-07T00:02:07.6115602Z Task         : Get sources
2019-08-07T00:02:07.6115650Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@alexcrichton

This comment has been minimized.

Copy link
Member

alexcrichton commented Aug 7, 2019

@bors: r+

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 7, 2019

📌 Commit ebb648d has been approved by alexcrichton

@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 7, 2019

⌛️ Testing commit ebb648d with merge ad7c55e...

bors added a commit that referenced this pull request Aug 7, 2019
redox: convert to target_family unix

This is the second step to supporting #60139.

In order to have a smooth transition, there will need to be a change made in liblibc at the same time, switching Redox over to the unix target family. See rust-lang/libc#1332
@bors

This comment has been minimized.

Copy link
Contributor

bors commented Aug 7, 2019

☀️ Test successful - checks-azure
Approved by: alexcrichton
Pushing ad7c55e to master...

@bors bors added the merged-by-bors label Aug 7, 2019
@bors bors merged commit ebb648d into rust-lang:master Aug 7, 2019
5 checks passed
5 checks passed
homu Test successful
Details
pr Build #20190807.3 succeeded
Details
pr (Linux mingw-check) Linux mingw-check succeeded
Details
pr (Linux x86_64-gnu-llvm-6.0) Linux x86_64-gnu-llvm-6.0 succeeded
Details
pr (LinuxTools) LinuxTools succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.