Add riscv64gc-unknown-linux-gnu image
#1684
Conversation
|
Seems ctest needs to add that target: Hey @gnzlbg, would you mind inviting me to ctest repo as a collaborator? Or if you have time to review, I'm happy to submit a PR! |
|
☔ The latest upstream changes (presumably #1695) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Okay, CI is now green. |
| @@ -2657,7 +2658,7 @@ fn test_linux(target: &str) { | |||
| (struct_ == "timex" && field.starts_with("__unused")) || | |||
| // FIXME: It now takes mode_t since glibc 2.31 on some targets. | |||
| (struct_ == "ipc_perm" && field == "mode" | |||
| && ((x86_64 || i686 || arm) && gnu || x86_64_gnux32) | |||
| && ((x86_64 || i686 || arm || riscv64) && gnu || x86_64_gnux32) | |||
There was a problem hiding this comment.
ipc_perm now uses mode_t everywhere.
There was a problem hiding this comment.
Skipping this because it was introduced in the newest version of glibc and I'd like to wait for a while. On riscv, isn't it newer change?
|
I have been building rust for riscv64 sucessfully for some time now, see https://build.opensuse.org/package/show/openSUSE:Factory:RISCV/rust and https://build.opensuse.org/package/show/home:Andreas_Schwab:riscv:rust/rust. |
| ENV CARGO_TARGET_RISCV64GC_UNKNOWN_LINUX_GNU_LINKER=riscv64-linux-gnu-gcc \ | ||
| CARGO_TARGET_RISCV64GC_UNKNOWN_LINUX_GNU_RUNNER="qemu-riscv64 -L /usr/riscv64-linux-gnu" \ | ||
| CC_riscv64gc_unknown_linux_gnu=riscv64-linux-gnu-gcc \ | ||
| CFLAGS_riscv64gc_unknown_linux_gnu="-mabi=lp64d -fPIC" \ |
There was a problem hiding this comment.
I think this is only needed because rust is still using llvm9, with llvm10 the riscv64gc-unknown-linux-gnu target should use the proper defaults now.
|
This PR makes some fields private that shouldn't be public so I believe the build shouldn't be broken unless someone depends on that accidentally. |
|
So, I'd like to merge this since it seems not to affect current behavior. Thanks all for reviewing! |
r? @ghost