Add RLIMIT_* constants for RISC-V 64-bit GNU/Linux and minor fixes for type definitions #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rust_highfive has picked a reviewer for you, use r? to override) |
msizanoen1
referenced
this pull request
in nix-rust/nix
Apr 25, 2020
|
That doesn't make sense. PTRACE_GETREGS, PTRACE_SETREGS, PTRACE_GETFPREGS, PTRACE_SETFPREGS, PTRACE_GETFPXREGS, PTRACE_SETFPXREGS don't exist on riscv64, and PTRACE_PEEKSIGINFO_SHARED is not architecture dependent. |
msizanoen1
force-pushed
the
riscv-add-constants
branch
from
b1856e2
to
5509977
Compare
|
I checked and it seems like those constants are not in the Linux headers for riscv64 but it is still in the glibc headers and therefore is mistakenly included. |
|
PTRACE_PEEKSIGINFO_SHARED is arch-independent but is not present in arch-independent files so this should be fixed in another PR. |
msizanoen1
force-pushed
the
riscv-add-constants
branch
from
5509977
to
938ad95
Compare
msizanoen1
changed the title
|
There is still another part of this PR for minor type definition fixes by removing redundant type definitions that is already in the platform-independent type defintions. |
tblah
added a commit
to tblah/rustup
that referenced
this pull request
Apr 28, 2020
This just forces effective-limits to use a patched libc with riscv64-unknown-linux-gnu support for RLIMIT constants. See rust-lang/libc#1745
3 tasks
tblah
added a commit
to tblah/effective-limits.rs
that referenced
this pull request
Apr 29, 2020
The riscv65gc-unknown-linux-gnu target requires fixes in rust-lang/libc#1745. These are merged but aren't in a release yet.
tblah
added a commit
to tblah/rustup
that referenced
this pull request
Apr 29, 2020
This just forces effective-limits to use a patched libc with riscv64-unknown-linux-gnu support for RLIMIT constants. See rust-lang/libc#1745
tblah
added a commit
to tblah/rustup
that referenced
this pull request
Apr 29, 2020
This just forces effective-limits to use a patched libc with riscv64-unknown-linux-gnu support for RLIMIT constants. See rust-lang/libc#1745
Merged
tblah
added a commit
to tblah/effective-limits.rs
that referenced
this pull request
May 13, 2020
libc 0.2.70 includes rust-lang/libc#1745 which fixes compilation for riscv64gc-unknown-linux-gnu.
rbtcollins
pushed a commit
to rbtcollins/effective-limits.rs
that referenced
this pull request
May 25, 2020
libc 0.2.70 includes rust-lang/libc#1745 which fixes compilation for riscv64gc-unknown-linux-gnu.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.