Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed for DragonFly #194

Merged
merged 2 commits into from
Feb 21, 2016
Merged

Fixed for DragonFly #194

merged 2 commits into from
Feb 21, 2016

Conversation

mneumann
Copy link
Contributor

Running libc-test: PASSED 3426 tests

Squashed commit of the following:

commit 1a7ee71
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:30:56 2016 +0100

Fix RLIM_POSIXLOCKS ->  RLIMIT_POSIXLOCKS

commit 09c49a9
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:29:24 2016 +0100

Ignore signedness check for uuid_t on DragonFly

commit aab4d11
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:23:21 2016 +0100

Move FreeBSD-only function into freebsd/mod.rs

commit 9921f03
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:21:42 2016 +0100

Move POSIX_FADV_* to freebsd/mod.rs

commit 2921c2d
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:20:11 2016 +0100

Fix signedness of blksize_t for DragonFly

commit 65e817b
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:19:02 2016 +0100

Fix Q_{GET,SET}QUOTA for DragonFly

commit a0d2d63
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:17:27 2016 +0100

Fix RLIMIT_* for DragonFly

commit d04a160
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:12:09 2016 +0100

Fix ELAST for DragonFly

commit d120b92
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:10:28 2016 +0100

Fix F_GETLK, F_SETLK, F_SETLKW for DragonFly

commit 963f7da
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:08:51 2016 +0100

Fix O_CLOEXEC for DragonFly

commit f4d6c9d
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:07:18 2016 +0100

Fix RAND_MAX for DragonFly

commit ba48336
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 13:04:48 2016 +0100

Fix statvfs for DragonFly

commit 9ae480c
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 12:51:47 2016 +0100

Fix fd_set for DragonFly

commit a15e027
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 12:42:24 2016 +0100

Fix all remaining issues on DragonFly

Missing functions and missing constats.

commit 3966e4f
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 12:27:14 2016 +0100

Use a macro instead of a constant.

When using a constant, the libc-test thinks this constant
exists as an C equivalent.

commit 9b5659a
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 12:21:01 2016 +0100

Use a constant in utsname

commit 50484ed
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 12:17:55 2016 +0100

Fix struct utsname

commit 832e942
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 12:07:08 2016 +0100

DragonFly has different stat, dirent, clock_t, ino_t, nlink_t, blksize_t

commit f3152a3
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 11:52:54 2016 +0100

Move DragonFly related stuff into dragonfly/*

Replicate x86_64.rs from FreeBSD. Need some twists.

commit 9fe3512
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 11:49:38 2016 +0100

Move FreeBSD code under freebsd/*.

Next commit will replicate some of the architecture dependent stuff
for DragonFly.

commit e91983d
Author: Michael Neumann mneumann@ntecs.de
Date: Sat Feb 20 11:44:25 2016 +0100

struct utsname has a different size on DragonFly

Running libc-test: PASSED 3426 tests

commit 1a7ee71
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:30:56 2016 +0100

    Fix RLIM_POSIXLOCKS ->  RLIMIT_POSIXLOCKS

commit 09c49a9
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:29:24 2016 +0100

    Ignore signedness check for uuid_t on DragonFly

commit aab4d11
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:23:21 2016 +0100

    Move FreeBSD-only function into freebsd/mod.rs

commit 9921f03
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:21:42 2016 +0100

    Move POSIX_FADV_* to freebsd/mod.rs

commit 2921c2d
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:20:11 2016 +0100

    Fix signedness of blksize_t for DragonFly

commit 65e817b
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:19:02 2016 +0100

    Fix Q_{GET,SET}QUOTA for DragonFly

commit a0d2d63
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:17:27 2016 +0100

    Fix RLIMIT_* for DragonFly

commit d04a160
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:12:09 2016 +0100

    Fix ELAST for DragonFly

commit d120b92
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:10:28 2016 +0100

    Fix F_GETLK, F_SETLK, F_SETLKW for DragonFly

commit 963f7da
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:08:51 2016 +0100

    Fix O_CLOEXEC for DragonFly

commit f4d6c9d
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:07:18 2016 +0100

    Fix RAND_MAX for DragonFly

commit ba48336
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 13:04:48 2016 +0100

    Fix statvfs for DragonFly

commit 9ae480c
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 12:51:47 2016 +0100

    Fix fd_set for DragonFly

commit a15e027
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 12:42:24 2016 +0100

    Fix all remaining issues on DragonFly

    Missing functions and missing constats.

commit 3966e4f
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 12:27:14 2016 +0100

    Use a macro instead of a constant.

    When using a constant, the libc-test thinks this constant
    exists as an C equivalent.

commit 9b5659a
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 12:21:01 2016 +0100

    Use a constant in utsname

commit 50484ed
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 12:17:55 2016 +0100

    Fix struct utsname

commit 832e942
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 12:07:08 2016 +0100

    DragonFly has different stat, dirent, clock_t, ino_t, nlink_t, blksize_t

commit f3152a3
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 11:52:54 2016 +0100

    Move DragonFly related stuff into dragonfly/*

    Replicate x86_64.rs from FreeBSD. Need some twists.

commit 9fe3512
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 11:49:38 2016 +0100

    Move FreeBSD code under freebsd/*.

    Next commit will replicate some of the architecture dependent stuff
    for DragonFly.

commit e91983d
Author: Michael Neumann <mneumann@ntecs.de>
Date:   Sat Feb 20 11:44:25 2016 +0100

    struct utsname has a different size on DragonFly
match c {
"LARGE_INTEGER" |
"mach_timebase_info_data_t" |
"float" |
"double" => true,
"uuid_t" if dragonfly => true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment here that this isn't an integer?

@alexcrichton
Copy link
Member

Nice! Thanks @mneumann! Looks like there's some CI failures as well?

If you're interested, I'd be totally fine adding a dragonfly builder on Travis via QEMU (there's some instructions in the ci folder) as well!

See comments #194.

Note on struct utsname: Neither using a constant, nor a conditional
macro seems to work, so I just created an ugly utsname with conditions
on each field. This should also fix the CI fallout. #[cfg] on macros
doesn't work?

As DragonFly only supports one platform, I merged  x86_64.rs into
dragonfly/mod.rs.
@mneumann
Copy link
Contributor Author

@alexcrichton : Thanks for the suggestions! Regarding CI, I am pretty busy with my thesis atm, but once I finish, I will take a look. This is definitively something we want to have!

alexcrichton added a commit that referenced this pull request Feb 21, 2016
@alexcrichton alexcrichton merged commit b57e312 into rust-lang:master Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants