Fix thread_state64 on aarch64-apple-darwin
#1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnTitor: no appropriate reviewer found, use r? to override |
JohnTitor
force-pushed
the
arm-macos-state64
branch
from
9d96b67
to
9906599
Compare
|
@syrusakbary Could you confirm if this patch works on your end? I cannot do by myself as not having Apple Silicon Mac. And cc @shepmaster could you also review this as you're familiar with this target? |
|
@bors r+ |
|
📌 Commit 9906599 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 12, 2020
Fix `thread_state64` on `aarch64-apple-darwin` Fixes #1977
|
💔 Test failed - checks-actions |
|
@bors r+ |
|
📌 Commit 36f9c1f has been approved by |
bors
added a commit
that referenced
this pull request
Dec 12, 2020
Fix `thread_state64` on `aarch64-apple-darwin` Fixes #1977
|
💥 Test timed out |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
bors
added a commit
that referenced
this pull request
Jan 5, 2021
Make test suite pass on macOS on aarch64 While working on #2007 I tried to run `cargo test` in `libc-test`, which failed, because the definition of `__darwin_mcontext64` was incomplete (see #1990). This adds definitions for the exception state and the floating point state as well. `libc-test` still does not pass, because I use the type `[u128; 32]` for the `__v` field of `__darwin_arm_neon_state64` (in C it is `__uint128_t __v[32]`. `ctest2` does not translate `u128` to `__uint128_t` and the generated C code does not compile. Any ideas for working around this?
bors
added a commit
that referenced
this pull request
Jan 5, 2021
Make test suite pass on macOS on aarch64 While working on #2007 I tried to run `cargo test` in `libc-test`, which failed, because the definition of `__darwin_mcontext64` was incomplete (see #1990). This adds definitions for the exception state and the floating point state as well. `libc-test` still does not pass, because I use the type `[u128; 32]` for the `__v` field of `__darwin_arm_neon_state64` (in C it is `__uint128_t __v[32]`. `ctest2` does not translate `u128` to `__uint128_t` and the generated C code does not compile. Any ideas for working around this?
Hywan
added a commit
to wasmerio/wasmer
that referenced
this pull request
Mar 5, 2021
Since libc 0.2.82, the issue rust-lang/libc#1977 has been fixed with rust-lang/libc#1990. Our current version of libc is 0.2.87. Let's update our code to remove the `__darwin_arm_thread_state64` type, and use the one from libc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1977