unbreak OpenBSD tests: iconv.h doesn't exist #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
|
r? @Amanieu (as you r+ iconv bindings) |
|
@bors r+ |
|
📌 Commit 915d8fa has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
|
thanks |
bors
added a commit
that referenced
this pull request
Feb 12, 2021
Remove unused iconv.h includes These are left over from 3e4d684, which added includes to *all* platforms despite adding bindings only to *some* of them. This already broke OpenBSD which doesn't have iconv.h (fixed by 915d8fa), and is just distasteful, so down with those unused includes. (This is a continuation to #2037 and #2067.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.