Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unbreak openbsd after #2109 #2136

Merged
merged 1 commit into from Apr 4, 2021
Merged

Conversation

semarie
Copy link
Contributor

@semarie semarie commented Apr 4, 2021

several symbols added to semver regression tests in "unix" aren't defined on OpenBSD.
move these symbols in OS specific files.

@rust-highfive
Copy link

r? @Amanieu

(rust-highfive has picked a reviewer for you, use r? to override)

several symbols added to semver regression tests in "unix" aren't defined on OpenBSD.
move these symbols in OS specific files.
Copy link
Member

@JohnTitor JohnTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and sorry for the breakage, the new semver test is experimental and needs some love.

@JohnTitor
Copy link
Member

r? @JohnTitor @bors r+

@bors
Copy link
Contributor

bors commented Apr 4, 2021

📌 Commit 08ec0d6 has been approved by JohnTitor

@bors
Copy link
Contributor

bors commented Apr 4, 2021

⌛ Testing commit 08ec0d6 with merge 3022d10...

bors added a commit that referenced this pull request Apr 4, 2021
unbreak openbsd after #2109

several symbols added to semver regression tests in "unix" aren't defined on OpenBSD.
move these symbols in OS specific files.
@bors
Copy link
Contributor

bors commented Apr 4, 2021

💔 Test failed - checks-actions

@semarie
Copy link
Contributor Author

semarie commented Apr 4, 2021

homu failed due to network problem:

  • Docker Switch : Get https://registry-1.docker.io/v2/: net/http: request canceled (Client.Timeout exceeded while awaiting headers)
  • Docker Linux Tier2 (mipsel-unknown-linux-musl) : Head https://registry-1.docker.io/v2/library/ubuntu/manifests/20.04: Get https://auth.docker.io/token?account=githubactions&scope=repository%3Alibrary%2Fubuntu%3Apull&service=registry.docker.io: EOF

@JohnTitor
Copy link
Member

 Step 1/7 : FROM ubuntu:20.04
Head registry-1.docker.io/v2/library/ubuntu/manifests/20.04: Get auth.docker.io/token?account=githubactions&scope=repository%3Alibrary%2Fubuntu%3Apull&service=registry.docker.io: EOF

I remember this failure happened on rust-lang/rust yesterday, docker.io is fragile recently... @bors retry

@bors
Copy link
Contributor

bors commented Apr 4, 2021

⌛ Testing commit 08ec0d6 with merge 95e259f...

@bors
Copy link
Contributor

bors commented Apr 4, 2021

☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13
Approved by: JohnTitor
Pushing 95e259f to master...

@bors bors merged commit 95e259f into rust-lang:master Apr 4, 2021
@semarie semarie deleted the openbsd-semver branch April 4, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants