apple add mach_vm_map, mmap does not provide custom alignment so #2283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
|
We've deprecated mach-related items since #1364 and a change like this should go to the |
|
I thought that but the crate had not been updated since 2019. Seems the maintainer is not responsive these days fitzgen/mach#63 |
JohnTitor
approved these changes
Jul 13, 2021
JohnTitor
reviewed
Jul 13, 2021
| @@ -1700,6 +1700,7 @@ mach_port_t | |||
| mach_thread_self | |||
| mach_timebase_info | |||
| mach_timebase_info_data_t | |||
| mach_vm_map | |||
There was a problem hiding this comment.
Ah, the list seems incomplete for the changes in this PR.
mach_vm_map is only way.
|
@bors r+ |
|
📌 Commit d5bb01c has been approved by |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mach_vm_map is only way.