Add SIGRTMAX and SIGRTMIN on linux-like systems #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) soon. Please see the contribution instructions for more information. |
JohnTitor
requested changes
Jul 29, 2021
JohnTitor
approved these changes
Jul 29, 2021
|
Thanks! |
|
📌 Commit 91dd411 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 29, 2021
Add SIGRTMAX and SIGRTMIN on linux-like systems Fixes #1883. This is based on #2195, which has not seen activity in a while. The original issue was resolved by making `__libc_current_sigrtmax` and `__libc_current_sigrtmax` `pub`. I also added a test similar to `errqueue`'s, where the actual value of the macro is compared to `libc`'s implementation. Closes #2195
|
Looks like the Should I remove the |
|
💔 Test failed - checks-actions |
|
Ah yes! I forgot that |
|
Done. 👍 |
|
@bors r+ |
|
📌 Commit 8af1a48 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 29, 2021
Add SIGRTMAX and SIGRTMIN on linux-like systems Fixes #1883. This is based on #2195, which has not seen activity in a while. The original issue was resolved by making `__libc_current_sigrtmax` and `__libc_current_sigrtmax` `pub`. I also added a test similar to `errqueue`'s, where the actual value of the macro is compared to `libc`'s implementation. Closes #2195
|
💔 Test failed - checks-actions |
|
@bors retry |
|
☀️ Test successful - checks-actions, checks-cirrus-freebsd-11, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1883. This is based on #2195, which has not seen activity in a while.
The original issue was resolved by making
__libc_current_sigrtmaxand__libc_current_sigrtmaxpub.I also added a test similar to
errqueue's, where the actual value of the macro is compared tolibc's implementation.Closes #2195