Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

illumos: Remove obsolete (and private) a.out define #2969

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

pfmooney
Copy link
Contributor

This cleans up an obsolete definition which has been removed in upstream illumos, and thus is causing libc-test to fail on up-to-date machines.

@rust-highfive
Copy link

Some changes occurred in solarish module

cc @jclulow,@pfmooney

@rust-highfive
Copy link

r? @JohnTitor

(rust-highfive has picked a reviewer for you, use r? to override)

@JohnTitor
Copy link
Member

Could you deprecate it first instead of deleting directly? See https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy for the reason.

@pfmooney
Copy link
Contributor Author

Could you deprecate it first instead of deleting directly? See https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy for the reason.

I can, if you insist.

This was part of a Private (not documented and subject to change/removal at any time) OS interface which probably should not have been added to rust-libc in the first place. As noted in the ticket for removing a.out exec functionality, support was limited to SPARC (which itself is deprecated on illumos). AFAIK, no work has been done to support Rust on illumos on SPARC.

All that said, I'll defer to what you think best.

Thanks.

@JohnTitor
Copy link
Member

Thanks for clarifying! So, hmm, I guess we could assume there's no real user (or misunderstanding use) then. Given that, it seems okay to accept as-is. @bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2022

📌 Commit bb88154 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 23, 2022

⌛ Testing commit bb88154 with merge 71b864d...

@bors
Copy link
Contributor

bors commented Oct 23, 2022

☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14
Approved by: JohnTitor
Pushing 71b864d to master...

@bors bors merged commit 71b864d into rust-lang:master Oct 23, 2022
@pfmooney pfmooney deleted the illumos-aout branch August 9, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants