-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
illumos: Remove obsolete (and private) a.out define #2969
Conversation
r? @JohnTitor (rust-highfive has picked a reviewer for you, use r? to override) |
Could you deprecate it first instead of deleting directly? See https://github.com/rust-lang/libc/blob/master/CONTRIBUTING.md#breaking-change-policy for the reason. |
I can, if you insist. This was part of a Private (not documented and subject to change/removal at any time) OS interface which probably should not have been added to rust-libc in the first place. As noted in the ticket for removing All that said, I'll defer to what you think best. Thanks. |
Thanks for clarifying! So, hmm, I guess we could assume there's no real user (or misunderstanding use) then. Given that, it seems okay to accept as-is. @bors r+ |
☀️ Test successful - checks-actions, checks-cirrus-freebsd-12, checks-cirrus-freebsd-13, checks-cirrus-freebsd-14 |
This cleans up an obsolete definition which has been removed in upstream illumos, and thus is causing libc-test to fail on up-to-date machines.