Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux SCTP support part 2 #3117

Closed
wants to merge 1 commit into from
Closed

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Feb 12, 2023

Fixes #2962

@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2023

r? @JohnTitor

(rustbot has picked a reviewer for you, use r? to override)

@nathaniel-bennett
Copy link
Contributor

Resolves #2962

@devnexen devnexen force-pushed the linux_sctp2 branch 2 times, most recently from aff6346 to 027ee5c Compare February 13, 2023 18:43
@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 14, 2023

📌 Commit 95f10cc has been approved by JohnTitor

It is now in the queue for this repository.

bors added a commit that referenced this pull request Feb 14, 2023
@bors
Copy link
Contributor

bors commented Feb 14, 2023

⌛ Testing commit 95f10cc with merge dc87bb2...

@bors
Copy link
Contributor

bors commented Feb 14, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Feb 21, 2023

📌 Commit a79c3a1 has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Feb 21, 2023

⌛ Testing commit a79c3a1 with merge b86fa3d...

bors added a commit that referenced this pull request Feb 21, 2023
@bors
Copy link
Contributor

bors commented Feb 21, 2023

💔 Test failed - checks-actions

@@ -3137,6 +3137,7 @@ fn test_linux(target: &str) {
"netdb.h",
"netinet/in.h",
"netinet/ip.h",
//"netinet/sctp.h",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is because the header is too new here, right? If so, a FIXME comment would helpful when upgrading CI images.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just not necessary at the moment.

@bors
Copy link
Contributor

bors commented Mar 12, 2023

☔ The latest upstream changes (presumably #3136) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Contributor

bors commented Apr 3, 2023

☔ The latest upstream changes (presumably #3155) made this pull request unmergeable. Please resolve the merge conflicts.

@JohnTitor
Copy link
Member

@bors +

It'd be great if you could @'rustbot review once a new change is pushed. I usually check on-review labeled PRs ('cause this repo has a lot of PRs... 🙇)

@devnexen
Copy link
Contributor Author

devnexen commented Apr 4, 2023

@rustbot review

@JohnTitor
Copy link
Member

And I forgot r:
@bors r+

@bors
Copy link
Contributor

bors commented Apr 4, 2023

📌 Commit 284e9ff has been approved by JohnTitor

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Apr 4, 2023

⌛ Testing commit 284e9ff with merge 79ea29f...

bors added a commit that referenced this pull request Apr 4, 2023
@bors
Copy link
Contributor

bors commented Apr 4, 2023

💔 Test failed - checks-actions

@JohnTitor
Copy link
Member

Failed on sparc64:

 rust[8] = 0 != 8 (C): Rust "sctp_shutdown_event" -> C
rust[9] = 0 != 9 (C): Rust "sctp_shutdown_event" -> C
rust[10] = 0 != 10 (C): Rust "sctp_shutdown_event" -> C
rust[11] = 0 != 11 (C): Rust "sctp_shutdown_event" -> C
rust [16] = 239 != 0 (C): C "sctp_authkey_event" -> Rust
rust [17] = 238 != 0 (C): C "sctp_authkey_event" -> Rust
rust [18] = 237 != 0 (C): C "sctp_authkey_event" -> Rust
rust [19] = 236 != 0 (C): C "sctp_authkey_event" -> Rust
rust[8] = 0 != 8 (C): Rust "sctp_sender_dry_event" -> C
rust[9] = 0 != 9 (C): Rust "sctp_sender_dry_event" -> C
rust[10] = 0 != 10 (C): Rust "sctp_sender_dry_event" -> C
rust[11] = 0 != 11 (C): Rust "sctp_sender_dry_event" -> C
rust [16] = 239 != 0 (C): C "sctp_assoc_reset_event" -> Rust
rust [17] = 238 != 0 (C): C "sctp_assoc_reset_event" -> Rust
rust [18] = 237 != 0 (C): C "sctp_assoc_reset_event" -> Rust
rust [19] = 236 != 0 (C): C "sctp_assoc_reset_event" -> Rust

@JohnTitor
Copy link
Member

Closing as inactive, feel free to re-submit a PR if you're still interested in this change. Thanks anyway!

@JohnTitor JohnTitor closed this Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding SCTP support (Linux/FreeBSD)
5 participants