Add missing Linux kernel header reference comment #3623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use r? to explicitly pick a reviewer |
|
It's a trivial PR, but while writing #3622, I noticed that the section with futex constants were missing a comment referencing the corresponding Linux kernel header, unlike everything else in that module. |
|
Thank you for the PR! We don't have any policy around such a comment and we have to decide if it's necessary for us or not before accepting this PR (note that existing comments were added by past contributors with practical patches). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a comment referencing the
linux/futex.hkernel header above the futex constants inunix/linux_like/linux/mod.rs.