Remove extra traits #3692
Open
Remove extra traits #3692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @JohnTitor (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
rj00a
commented
May 10, 2024
| @@ -140,9 +139,6 @@ fn check_style(file: &str, path: &Path, err: &mut Errors) { | |||
| } else if line.starts_with("type ") && !in_impl { | |||
| State::Typedefs | |||
| } else if line.starts_with("s! {") { | |||
| s_macros += 1; | |||
There was a problem hiding this comment.
I had to allow multiple s! macros in one module because the s_no_extra_traits! macro no longer exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
extra_traitsfeature and all implementations ofEq,Hash, andDebugas mentioned in #3248.The decision to remove
Debugimpls was left as an open question, but I've gone ahead and removed them here in the interest of maintainability and consistency.Closes #2700, #2064, #2816