Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement fmod #21

Closed
japaric opened this issue Jul 12, 2018 · 1 comment · Fixed by #84
Closed

implement fmod #21

japaric opened this issue Jul 12, 2018 · 1 comment · Fixed by #84
Labels
good first issue Good for newcomers
Milestone
wasm

Comments

@japaric
Copy link
Member

japaric commented Jul 12, 2018

Source: https://git.musl-libc.org/cgit/musl/tree/src/math/fmod.c
@japaric japaric added the help wanted Extra attention is needed label Jul 12, 2018
@japaric japaric added this to the wasm milestone Jul 12, 2018
@japaric japaric added the good first issue Good for newcomers label Jul 12, 2018
@P1n3appl3 P1n3appl3 mentioned this issue Jul 14, 2018
Merged
bors bot added a commit that referenced this issue Jul 14, 2018
@bors @P1n3appl3
Merge #84
2d9a73c 
84: Implement fmod r=japaric a=P1n3appl3

closes #21 
I replaced the `isnanf()` function from `fmodf()` with a call to the core function `is_nan()`. If there's a reason we needed to re-implement it then I can change that back.

Also I couldn't figure out what to do in `src/lib.rs`. Is the `#[cfg(todo]` that I should be removing the one for `mod_euc()`? If so why is the equivalent one for the `f64` version still there?

Co-authored-by: Joseph Ryan <josephryan3.14@gmail.com>
bors bot added a commit that referenced this issue Jul 14, 2018
@bors @P1n3appl3 @japaric
Merge #84
cd0fed2 
84: Implement fmod r=japaric a=P1n3appl3

closes #21 
I replaced the `isnanf()` function from `fmodf()` with a call to the core function `is_nan()`. If there's a reason we needed to re-implement it then I can change that back.

Also I couldn't figure out what to do in `src/lib.rs`. Is the `#[cfg(todo]` that I should be removing the one for `mod_euc()`? If so why is the equivalent one for the `f64` version still there?

Co-authored-by: Joseph Ryan <josephryan3.14@gmail.com>
Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@japaric
Copy link
Member Author

japaric commented Jul 14, 2018

PR #84 implements this

@japaric japaric removed the help wanted Extra attention is needed label Jul 14, 2018
bors bot added a commit that referenced this issue Jul 14, 2018
@bors @P1n3appl3 @japaric
Merge #84
c22bd25 
84: Implement fmod r=japaric a=P1n3appl3

closes #21 
I replaced the `isnanf()` function from `fmodf()` with a call to the core function `is_nan()`. If there's a reason we needed to re-implement it then I can change that back.

Also I couldn't figure out what to do in `src/lib.rs`. Is the `#[cfg(todo]` that I should be removing the one for `mod_euc()`? If so why is the equivalent one for the `f64` version still there?

Co-authored-by: Joseph Ryan <josephryan3.14@gmail.com>
Co-authored-by: Jorge Aparicio <jorge@japaric.io>
@bors bors bot closed this as completed in #84 Jul 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
wasm
Development

Successfully merging a pull request may close this issue.

Implement fmod
1 participant
@japaric