Change sqrt to use wrapping newtypes
#142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 1, 2018
|
@japaric hi, any plans on merging this one and related PRs? |
alexcrichton
force-pushed
the
wrapping-sqrt
branch
from
e8173e8
to
339502c
Compare
|
Sorry for the very long delay on merging this but looks like this still passes tests (yay!) so I'm going to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the
sqrtimplementation to use theWrappingnewtype around theu32s to make it not panic on overflows. This seems to be enough to makesqrtwork with overflow checks enabled.Helps #4.