This repository has been archived by the owner on Feb 5, 2019. It is now read-only.
Freebsd Fixes for LLVM 4.0 #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When testing whether we need to pass `-Wl,-z,defs` the cmake files currently tests for FreeBSD, but only if the host system is FreeBSD. Instead we should test whether the target that we're compiling is FreeBSD so we correctly deduce that it should not be passed. * The `PATH_MAX` constant is defined in a different place for the dsymutil tool, so we just config that code out for now as it apparently doesn't include the right header?
they don't compile on (at least) freebsd and we don't need them
alexcrichton
pushed a commit
that referenced
this pull request
Jul 30, 2017
Freebsd Fixes for LLVM 4.0
alexcrichton
pushed a commit
that referenced
this pull request
Aug 4, 2017
Freebsd Fixes for LLVM 4.0
alexcrichton
pushed a commit
that referenced
this pull request
Aug 15, 2017
Freebsd Fixes for LLVM 4.0
alexcrichton
pushed a commit
that referenced
this pull request
Oct 10, 2017
Freebsd Fixes for LLVM 4.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains three FreeBSD specific fixes, for the fixes themselves see the commit messages.
(Note: While doing the final rebase / cleanup of the LLVM 4.0 upgrade I decided that it would probably be nice to have a PR # associated with each rust modification for future reference / discussion, thus this PR.)