New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fontawesome upgrade to 5.13; incl free brand solid #1225
Open
rubenmoor
wants to merge
18
commits into
rust-lang:master
Choose a base branch
from
rubenmoor:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add page title override: {{#title My Title}} * Document {{#title}} in guide
Includes new configuration option `git-repository-edit-baseurl` for supporting non-GitHub repository layouts.
…dependent of git_repository_url.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straightforward and tested.
However, for backwards compatibility, there are at least two options. At the moment, the upgrade breaks old
index.hbs
files - which is somewhat unnecessary. These oldindex.hbs
are encouraged to be kept as theme overrides and - only if that is the case - would have to be updated manually.The reason is simply that FontAwesome changed their filename from
font-awesome.css
tofontawesome.css
without the hyphen. The files are rewritten anyways, thusfont-awesome.css
font-awesome.css
andfontawesome.css
The new way to write would cause less confusion in the long run, being consistent with FontAwesome's naming.