Another attempt at updating FontAwesome to version 5 #1423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Kamil Vavra for responsibly disclosing the vulnerability according to Rust's Security Policy.
First, there is an official way to include all available FontAwesome fonts by using all.css Second, the previous attempt at updating to FontAwesome 5 missed the regular version That was not entirely the original PR author @rubenmoor 's fault though, because FA's docs regarding the partially available Regular style are unclear.
upstream 0.4.5: fix XSS in search
Upstream update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on #1225 .
But the original PR is incompatible with v4 icon namings, some older icons would still not work.
With the
v4-shims[.min].cssprovided by Font Awesome, that problem was solved; but some icons are replaced with the solid style instead of Regular, which was used by FA4.To sum it up, there are currently three problems of migrating to FontAwesome 5:
font-awesome.csstoall.cssnamingindex.hbs