Add --title option and --gitignore flag to mdbook init #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add init flags update init command in guide
joshrotenberg
force-pushed
the
title_ignore_flags_init
branch
from
18f9f78
to
e5e10c6
Compare
ehuss
reviewed
Jul 4, 2021
src/cmd/init.rs
Outdated
| @@ -18,14 +18,27 @@ pub fn make_subcommand<'a, 'b>() -> App<'a, 'b> { | |||
| ) | |||
| .arg_from_usage("--theme 'Copies the default theme into your source folder'") | |||
| .arg_from_usage("--force 'Skips confirmation prompts'") | |||
| .arg( | |||
| Arg::with_name("title") | |||
| .short("t") | |||
There was a problem hiding this comment.
I would probably drop the short flags for now. Unless an option is extremely common, I find it is generally more readable to use the long form.
There was a problem hiding this comment.
Removed the short values for ignore and title.
src/cmd/init.rs
Outdated
| println!("\nDo you want a .gitignore to be created? (y/n)"); | ||
|
|
||
| if confirm() { | ||
| if args.is_present("gitignore") { |
There was a problem hiding this comment.
There doesn't appear to be a way to pass "no" on the command-line for gitignore. Perhaps the flag should take a value? Maybe something like --ignore=git or --ignore=none?
There was a problem hiding this comment.
The arg is now --ingore and it either takes the value git (creates a .gitignore), none doesn't create a .gitignore, or if neither is present, the user is prompted.
ehuss
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new flags to
mdbook init;--titleand--gitignore.These flags optionally replace the two currently interactive prompts so that a book can be initialized without any prompts if desired.
See #1556.