Keep indent when using include in code block #1718
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchaser53
force-pushed
the
include-ident
branch
from
a1880e1
to
e22886a
Compare
|
Writing a book currently where I ran into the issue that is resolved in this PR. Are there any blockers for this to get merged? |
ISSOtm
approved these changes
Jun 18, 2022
mgeisler
reviewed
Sep 9, 2022
| // no need to add offset for the first line | ||
| replaced.push_str(lines[0]); | ||
| for line in lines.iter().skip(1) { | ||
| replaced.push_str(&format!("\n{}{}", &offset, &line)); |
There was a problem hiding this comment.
You could consider changing this to
replaced.push('\n');
replaced.push_str(&offset);
replaced.push_str(&line);since you're simply concatenating strings.
mgeisler
reviewed
Sep 9, 2022
| )); | ||
| let v = | ||
| replace_all(&new_content, rel_path, source, depth + 1, chapter_title); | ||
| let lines = v.split('\n').into_iter().collect::<Vec<&str>>(); |
There was a problem hiding this comment.
Since you're iterating over the lines one-by-one, you could iterate directly over the result of split. So you would save the collect() call be a tiny bit more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix issue 1626. mdBook ignores the indent in code block created by #include. I think this is the reason why issue 1626 happened. So I implemented to add the offset to the code block created by #include.
fix: #1626