Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Stylus to CSS #743

Merged
merged 9 commits into from Jul 26, 2018
Merged

Conversation

mattico
Copy link
Contributor

@mattico mattico commented Jul 26, 2018

A revival of #636.

Moving from Stylus has been discussed before, but to summarize:

  • Removes the need for node, npm, stylus, nib, and build.rs. This makes it easier to build and contribute, and also significantly improves build times.
  • Removes the confusion for users and contributors who don't notice that book.css isn't the real source for styling, or who don't understand Stylus syntax.
  • Makes it easy to provide an API for user-created CSS themes.
  • Using CSS variables for themes makes the output CSS much smaller due to reduced duplication (though we could use those with Stylus as well).

Here's what this PR does:

  • Convert Stylus to CSS (manually).
  • Remove Stylus supporting code and documentation.
  • Merge the many CSS files into 4 files.
    Having lots of small files is annoying to deal with in our current theme implementation (fixing that is
    another discussion), and it's bad for page load times. While we could use a build step to concatenate
    it's much simpler to not, and we don't actually have enough CSS to need many files. We could easily
    just have one stylesheet, but I liked having a little bit of organization.

@mattico mattico changed the title Remove stylus redux Convert Stylus to CSS Jul 26, 2018
@mattico mattico merged commit 028c8b0 into rust-lang:master Jul 26, 2018
@mattico mattico deleted the remove-stylus-redux branch July 26, 2018 20:37
Ruin0x11 pushed a commit to Ruin0x11/mdBook that referenced this pull request Aug 30, 2020
@ehuss ehuss mentioned this pull request Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant