[summarize] Implement diff support for comparing profiles
#50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
reviewed
Jun 19, 2019
|
|
||
| fn write_results_json(file: &PathBuf, results: impl Serialize) -> Result<(), Box<dyn Error>> { | ||
| let file = BufWriter::new(File::create(file.with_extension("json"))?); | ||
| serde_json::to_writer(file, &results)?; |
There was a problem hiding this comment.
I would do the same here -- instead of a BufWriter just write to a vec in memory.
There was a problem hiding this comment.
I think for now, I'd prefer to leave the standard BufReader`BufWriter` alone. These tools run pretty quick already so I don't think this is going to make a big difference.
|
I think this is ready to merge. @Mark-Simulacrum is that ok with you? |
Mark-Simulacrum
approved these changes
Jun 23, 2019
|
Feel free to merge when ready -- I forget if we have bors or anything setup here so won't do it myself in this case |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33