rustup for error reform #1219
Merged
rustup for error reform #1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
force-pushed
the
error-cleanup
branch
2 times, most recently
from
243b4f8
to
d6d5365
Compare
|
☔ The latest upstream changes (presumably #1227) made this pull request unmergeable. Please resolve the merge conflicts. |
we basically treat them as lang items
RalfJung
commented
Mar 19, 2020
| @@ -1,9 +1,9 @@ | |||
| fn main() { | |||
| fn f() {} | |||
| fn f() {} //~ ERROR calling a function with more arguments than it expected | |||
There was a problem hiding this comment.
Interestingly, the span moved here. Might have to do with switching to a try block?
There was a problem hiding this comment.
Ah it probably does, throw_*! macros internally use return so try no longer catches them oops
|
@bors r+ |
|
📌 Commit 49051e0 has been approved by |
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the Miri side of rust-lang/rust#69839.