Remove non-power-of-two SIMD vectors #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. :) |
|
Sure! Should I update it to that particular hash, or just the latest hash on master? |
|
Probably best to use that hash to ensure there's no interference with other changes that came in since then. |
oli-obk
reviewed
Feb 8, 2021
| @@ -7,10 +7,6 @@ struct i32x2(i32, i32); | |||
| #[repr(simd)] | |||
| #[derive(Copy, Clone, Debug, PartialEq)] | |||
| #[allow(non_camel_case_types)] | |||
| struct i32x3(i32, i32, i32); | |||
There was a problem hiding this comment.
we may need to reintroduce this (at least I was told in rust-lang/rust#27731 (comment) that we need to support these again). So we should probably have an issue that reminds us to re-add this once it works again
|
Thanks. :) |
|
📌 Commit 053124a has been approved by |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes rust-lang/rust#81868.