Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert --color=always changes #2283

Merged
merged 1 commit into from
Jun 29, 2022
Merged

revert --color=always changes #2283

merged 1 commit into from
Jun 29, 2022

Conversation

RalfJung
Copy link
Member

They cause problems and they completely break rendering on the playground:

   Compiling playground v0.0.1 (/playground)
    Finished dev [unoptimized + debuginfo] target(s) in 0.47s
     Running `/playground/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/bin/cargo-miri target/miri/x86_64-unknown-linux-gnu/debug/playground`
�[0m�[1m�[38;5;9merror[E0277]�[0m�[0m�[1m: `*mut std::sync::atomic::AtomicUsize` cannot be sent between threads safely�[0m
�[0m   �[0m�[0m�[1m�[38;5;12m--> �[0m�[0msrc/main.rs:17:18�[0m
�[0m    �[0m�[0m�[1m�[38;5;12m|�[0m
�[0m�[1m�[38;5;12m17�[0m�[0m  �[0m�[0m�[1m�[38;5;12m|�[0m�[0m   �[0m�[0m        let j1 = spawn(move || {�[0m
�[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m �[0m�[0m�[1m�[38;5;12m__________________�[0m�[0m�[1m�[38;5;9m^^^^^�[0m�[0m�[1m�[38;5;12m_-�[0m
�[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m                  �[0m�[0m�[1m�[38;5;9m|�[0m
�[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|�[0m�[0m                  �[0m�[0m�[1m�[38;5;9m`*mut std::sync::atomic::AtomicUsize` cannot be sent between threads safely�[0m
�[0m�[1m�[38;5;12m18�[0m�[0m  �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m            *(c.0 as *mut usize) = 32;�[0m
�[0m�[1m�[38;5;12m19�[0m�[0m  �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m�[1m�[38;5;12m|�[0m�[0m �[0m�[0m        });�[0m
�[0m    �[0m�[0m�[1m�[38;5;12m| �[0m�[0m�[1m�[38;5;12m|_________-�[0m�[0m �[0m�[0m�[1m�[38;5;12mwithin this `[closure@src/main.rs:17:24: 19:10]`�[0m
�[0m    �[0m�[0m�[1m�[38;5;12m|�[0m

Sorry @saethlin, I think we need to go back to start here and consider another solution.

Fixes #2277

@saethlin
Copy link
Member

Yeah, I should probably learn how color is actually managed between cargo/rustc

@RalfJung
Copy link
Member Author

@bors r+

@RalfJung RalfJung closed this Jun 29, 2022
@bors
Copy link
Collaborator

bors commented Jun 29, 2022

📌 Commit 6f7c0c0 has been approved by RalfJung

@RalfJung
Copy link
Member Author

wtf. Ctrl-enter closes PRs now? I hope Github can fix this quickly...

@RalfJung RalfJung reopened this Jun 29, 2022
@RalfJung
Copy link
Member Author

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

💡 This pull request was already approved, no need to approve it again.

  • There's another pull request that is currently being tested, blocking this pull request: Rustup #2281

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

📌 Commit 6f7c0c0 has been approved by RalfJung

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

⌛ Testing commit 6f7c0c0 with merge 062b660...

@bors
Copy link
Collaborator

bors commented Jun 29, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 062b660 to master...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo miri: can't disable colors
3 participants