Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up terminology: step 2 — more renaming, and using actual words #127

Merged
merged 1 commit into from
Oct 8, 2019

Conversation

lqd
Copy link
Member

@lqd lqd commented Sep 18, 2019

In which The Great Renaming ™ is basically done:

  • continues the region to origin migration in the rest of polonius-engine
  • renames MovePath to Path
  • more consistent terminology around loans (preferred to borrows or Bs)
  • uses words instead of single-letters in comments, datalog rules, datafrog closures, etc basically everywhere, for all Atoms
  • minor cleanups here and there

@lqd
Copy link
Member Author

lqd commented Sep 19, 2019

However, since the names are now more descriptive, should I remove some of the "types" which were added to describe the single-letters variables, from e.g.

the origin `origin` may refer to data from loan `loan` starting at the point `point`

to something like

the `origin` may refer to data from `loan` starting at `point`

?


edit: this has been done in following commits

@amandasystems
Copy link
Contributor

amandasystems commented Sep 19, 2019 via email

Renames `MovePath`s to `Path`s, instances of `borrow` or `B` to `loans`,
uses words instead of single-letter variables, etc.
@lqd lqd force-pushed the traveler_there_are_no_paths branch from f91c3d6 to e55aebe Compare October 3, 2019 12:07
@lqd
Copy link
Member Author

lqd commented Oct 3, 2019

rebased, squashed, and ready to go

@nikomatsakis nikomatsakis merged commit 0a65ede into rust-lang:master Oct 8, 2019
@lqd lqd deleted the traveler_there_are_no_paths branch October 8, 2019 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants