Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure: Add mechanism to validate SMIR #16

Closed
celinval opened this issue Jul 29, 2023 · 4 comments
Closed

Infrastructure: Add mechanism to validate SMIR #16

celinval opened this issue Jul 29, 2023 · 4 comments
Assignees
@celinval
Milestone
StableMIR 0.1

Comments

@celinval
Copy link
Contributor

celinval commented Jul 29, 2023 •
edited by rustbot
Loading

We need a better mechanism to validate StableMIR translation. Maybe a mini-interpreter or at least create a debug option that we can inspect.
@celinval celinval added this to the StableMIR 0.1 milestone Jul 29, 2023
@celinval celinval mentioned this issue Jul 29, 2023
Closed
@oli-obk
Copy link
Contributor

oli-obk commented Jul 29, 2023 •
edited
Loading

As a minimal first step we could create a dummy "codegen" that doesn't even monomorphize, but just tries to generate the MIR of all public items and all items needed by them.

Edit: ah you already said that in the linked issue

@ouz-a ouz-a mentioned this issue Aug 1, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Aug 1, 2023
@matthiaskrgr
Rollup merge of rust-lang#114320 - ouz-a:smir_statements, r=oli-obk
41364c7 
Cover statements for stable_mir

Added missing statements to stable_mir, used opaque types for few types that are only used for diagnostic.

cc rust-lang/project-stable-mir#16

r? `@oli-obk`
@celinval
Copy link
Contributor Author

celinval commented Aug 1, 2023

@rustbot claim

@celinval celinval self-assigned this Aug 1, 2023
github-actions bot pushed a commit to rust-lang/miri that referenced this issue Aug 2, 2023
@matthiaskrgr
Rollup merge of #114320 - ouz-a:smir_statements, r=oli-obk
2fe56b7 
Cover statements for stable_mir

Added missing statements to stable_mir, used opaque types for few types that are only used for diagnostic.

cc rust-lang/project-stable-mir#16

r? `@oli-obk`
@celinval celinval removed their assignment Aug 31, 2023
@celinval
Copy link
Contributor Author

@rustbot claim

@celinval
Copy link
Contributor Author

celinval commented Oct 25, 2023 •
edited
Loading

We added a regression suite and and dummy driver that inspect and test SMIR in #25

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@celinval celinval

Labels
None yet
Projects
None yet
Milestone
StableMIR 0.1
Development

No branches or pull requests
2 participants
@oli-obk @celinval