Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

Implement the THIR unsafety checker #7

Closed
13 tasks done
LeSeulArtichaut opened this issue Mar 14, 2021 · 2 comments
Closed
13 tasks done

Implement the THIR unsafety checker #7

LeSeulArtichaut opened this issue Mar 14, 2021 · 2 comments
Assignees
@LeSeulArtichaut
Projects
THIR Unsafeck Plan

Comments

@LeSeulArtichaut
Copy link
Contributor

LeSeulArtichaut commented Mar 14, 2021 •
edited
Loading

Unsafe operations
@LeSeulArtichaut LeSeulArtichaut added this to Active 🟢 in THIR Unsafeck Plan Mar 14, 2021
@LeSeulArtichaut LeSeulArtichaut self-assigned this Mar 14, 2021
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Mar 14, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue May 13, 2021
@bors
Auto merge of rust-lang#83129 - LeSeulArtichaut:thir-unsafeck, r=niko…
17b60b8 
…matsakis

Introduce the beginning of a THIR unsafety checker

This poses the foundations for the THIR unsafety checker, so that it can be implemented incrementally:
- implements a rudimentary `Visitor` for the THIR (which will definitely need some tweaking in the future)
- introduces a new `-Zthir-unsafeck` flag which tells the compiler to use THIR unsafeck instead of MIR unsafeck
- implements detection of unsafe functions
- adds revisions to the UI tests to test THIR unsafeck alongside MIR unsafeck

This uses a very simple query design, where bodies are unsafety-checked on a body per body basis. This however has some big flaws:
- the unsafety-checker builds the THIR itself, which means a lot of work is duplicated with MIR building constructing its own copy of the THIR
- unsafety-checking closures is currently completely wrong: closures should take into account the "safety context" in which they are created, here we are considering that closures are always a safe context

I had intended to fix these problems in follow-up PRs since they are always gated under the `-Zthir-unsafeck` flag (which is explicitely noted to be unsound).

r? `@nikomatsakis`
cc rust-lang/project-thir-unsafeck#3 rust-lang/project-thir-unsafeck#7
This was referenced May 13, 2021
Merged
Merged
@LeSeulArtichaut
Copy link
Contributor Author

@Smittyvb thanks for your help on this! If you plan on working on more unsafe operations, it would be great if you posted a comment here saying that you're doing it so we don't risk duplicate work. Or, if you intend to work regularly on this, you can ask to join the project group so you can edit the comment above directly.

@LeSeulArtichaut LeSeulArtichaut mentioned this issue May 14, 2021
Closed
bors added a commit to rust-lang-ci/rust that referenced this issue May 16, 2021
@bors
Auto merge of rust-lang#85259 - Smittyvb:thir-unsafeck-inline-asm, r=…
6d525d5 
…nikomatsakis

Check for inline assembly in THIR unsafeck

rust-lang#83129 was merged recently and added a THIR unsafe checker. This adds a check for inline assembly. (and this is 2x simpler than the MIR version, which has to check for `asm` and `llvm_asm` in two separate spots!)

 see also rust-lang/project-thir-unsafeck#7
This was referenced May 16, 2021
Closed
Closed
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 21, 2021
@GuillaumeGomez
Rollup merge of rust-lang#85306 - LeSeulArtichaut:thir-unsafeck, r=ni…
88f5744 
…komatsakis

Add DerefOfRawPointer and CallToFunctionWith to THIR unsafeck

Extends THIR unsafeck to check for two more cases of unsafe operations: dereferences of raw pointers and calls to functions with `#[target_feature]` (RFC 2396). The check for the latter is pretty much copy-pasted from the existing MIR equivalent.

This will clash with rust-lang#83842 and rust-lang#85273 which are arguably more important, let's maybe focus on getting those merged first, this can wait.
r? `@nikomatsakis`
cc rust-lang/project-thir-unsafeck#7
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this issue May 21, 2021
@GuillaumeGomez
Rollup merge of rust-lang#85419 - LeSeulArtichaut:thir-unsafeck-3, r=…
4f2416e 
…nikomatsakis

Check for use of mutable/extern statics in THIR unsafeck

Extends THIR unsafeck to check for use of mutable and extern statics.

r? `@ghost` (I don't want to flood Niko's review queue)
cc rust-lang/project-thir-unsafeck#7
@LeSeulArtichaut LeSeulArtichaut mentioned this issue May 22, 2021
Closed
@FabianWolff FabianWolff mentioned this issue Jun 27, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 9, 2021
@bors
Auto merge of rust-lang#85263 - Smittyvb:thir-unsafeck-union-field, r…
240ff4c 
…=oli-obk

Check for union field accesses in THIR unsafeck

see also rust-lang#85259, rust-lang#83129, rust-lang/project-thir-unsafeck#7

r? `@LeSeulArtichaut`
bors added a commit to rust-lang-ci/rust that referenced this issue Jul 13, 2021
@bors
Auto merge of rust-lang#86665 - FabianWolff:layout-field-thir-unsafec…
1f0db5e 
…k, r=oli-obk

Implement Mutation- and BorrowOfLayoutConstrainedField in thir-unsafeck

Since nobody has so far claimed Mutation- and BorrowOfLayoutConstrainedField in rust-lang/project-thir-unsafeck#7, I have taken the liberty of implementing them in thir-unsafeck.

r? `@LeSeulArtichaut`
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Jul 23, 2021
Merged
LeSeulArtichaut added a commit to LeSeulArtichaut/rust that referenced this issue Jul 24, 2021
@LeSeulArtichaut
Rollup merge of rust-lang#87403 - LeSeulArtichaut:assign-dropping-uni…
fa1bbfb 
…on, r=oli-obk

Implement `AssignToDroppingUnionField` in THIR unsafeck

r? `@oli-obk` cc rust-lang/project-thir-unsafeck#7
Manishearth added a commit to Manishearth/rust that referenced this issue Jul 24, 2021
@Manishearth
Rollup merge of rust-lang#87403 - LeSeulArtichaut:assign-dropping-uni…
075d3a1 
…on, r=oli-obk

Implement `AssignToDroppingUnionField` in THIR unsafeck

r? ``@oli-obk`` cc rust-lang/project-thir-unsafeck#7
@syvb
Copy link

syvb commented Jul 24, 2021

@LeSeulArtichaut It appears that all of the unsafe operations have been implemented, I think this should be closed.

@LeSeulArtichaut LeSeulArtichaut moved this from Active 🟢 to Done ✅ in THIR Unsafeck Plan Jul 24, 2021
@LeSeulArtichaut LeSeulArtichaut mentioned this issue Aug 23, 2021
Merged
m-ou-se added a commit to m-ou-se/rust that referenced this issue Aug 23, 2021
@m-ou-se
Rollup merge of rust-lang#88259 - LeSeulArtichaut:complete-thir-unsaf…
e710132 
…eck, r=oli-obk

Do not mark `-Z thir-unsafeck` as unsound anymore

The initial implementation of the THIR unsafety checker is now complete (rust-lang/project-thir-unsafeck#7).

r? `@oli-obk`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeSeulArtichaut LeSeulArtichaut

Labels
None yet
Projects
THIR Unsafeck Plan
Done ✅
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syvb @LeSeulArtichaut