Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for InitializingTypeWith and CastOfPointerToInt in THIR unsafeck #85381

Closed
wants to merge 2 commits into from
Closed

Check for InitializingTypeWith and CastOfPointerToInt in THIR unsafeck #85381

wants to merge 2 commits into from

Conversation

LeSeulArtichaut
Copy link
Contributor

@LeSeulArtichaut LeSeulArtichaut commented May 16, 2021 •
edited
Loading

Extends THIR unsafeck to check for two more cases of unsafe operations: initialization of layout-restricted types and ptr-to-int casts in const functions.

r? @ghost (I don't want to flood Niko's review queue)
cc rust-lang/project-thir-unsafeck#7

@LeSeulArtichaut LeSeulArtichaut mentioned this pull request May 16, 2021
Closed
13 tasks
@bors

This comment has been minimized.

Sign in to view
@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label May 19, 2021
@LeSeulArtichaut
Copy link
Contributor Author

r? @nikomatsakis

@LeSeulArtichaut LeSeulArtichaut added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 20, 2021
@nikomatsakis
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 21, 2021

📌 Commit afc8a38 has been approved by nikomatsakis

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 21, 2021
@GuillaumeGomez GuillaumeGomez mentioned this pull request May 21, 2021
Closed
@LeSeulArtichaut LeSeulArtichaut mentioned this pull request May 21, 2021
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 21, 2021
@GuillaumeGomez
Rollup merge of rust-lang#85555 - LeSeulArtichaut:thir-unsafeck, r=ni…
0f48e63 
…komatsakis

Check for more things in THIR unsafeck

Reunion of rust-lang#85306, rust-lang#85381 and rust-lang#85419 with conflicts resolved.
r? `@nikomatsakis`
@LeSeulArtichaut LeSeulArtichaut deleted the thir-unsafeck-2 branch May 24, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikomatsakis nikomatsakis nikomatsakis approved these changes

Assignees

@nikomatsakis nikomatsakis

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LeSeulArtichaut @bors @nikomatsakis