-
Notifications
You must be signed in to change notification settings - Fork 433
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This fixes yet another bug with our handling of (?flags) directives in the regex. This time, we try to be a bit more principled and specifically treat a (?flags) directive as a valid empty sub-expression. While this means we could remove errors reported from previous fixes for things like `(?i)+`, we retain those for now since they are a bit weird. Although `((?i))+` is now allowed, which is equivalent. We should probably allow `(?i)+` in the future for consistency sake. Fixes #527
- Loading branch information
1 parent
f0bdefb
commit ccfd843
Showing
3 changed files
with
22 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters