Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: fix some grammar #987

Merged
merged 2 commits into from
Apr 24, 2023
Merged

changelog: fix some grammar #987

merged 2 commits into from
Apr 24, 2023

Conversation

tshepang
Copy link
Member

No description provided.

CHANGELOG.md Outdated
@@ -39,7 +39,7 @@ years of on-and-off work that [began in earnest in March
2020](https://github.com/rust-lang/regex/issues/656).

Because of the scale of changes involved in these releases, I would love to
hear about your experience. Especially if you notice undocumented changes in
hear about your experience, especially if you notice undocumented changes in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change? It feels like a sentence that is too long to me.

Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@BurntSushi BurntSushi merged commit 1872bdf into rust-lang:master Apr 24, 2023
@tshepang tshepang deleted the patch-1 branch April 26, 2023 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants