Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments with negative IDs on rust-lang/rust #325

Open
apiraino opened this issue Jul 25, 2024 · 0 comments
Open

Comments with negative IDs on rust-lang/rust #325

apiraino opened this issue Jul 25, 2024 · 0 comments

Comments

@apiraino
Copy link

apiraino commented Jul 25, 2024

RFCbot started linking comments with a negative ID since we overflowed an i32 amount of comments in the rust-lang/rust repository.

Example: In this comment another comment was linked but the ID of the linked comment is wrong. Instead of being #issuecomment-2250077004 it's a negative comment ID (#issuecomment--2044890292) .

The GH documentation suggests storing these ID as i64 (comment on Zulip) but we store them as i32 (code, IIUC the rfcbot DB).

I wonder if it would make sense attempting to migrate these IDs to i64.

Relevant discussions on Zulip: here, here and here.

Relevant patches: 4616cbd and 20ee406 and f9d84fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant