Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amend #1268 with a more feasible proposal post-specialization #1600

Closed
wants to merge 1 commit into from

Conversation

sgrif
Copy link
Contributor

@sgrif sgrif commented Apr 30, 2016

I took a swing at implementing the original RFC, and it became clear that it made much more sense when described as a modifier to specialization, rather that treating marker traits differently. After writing a proof of concept implementation, I believe this is the easier path forward.

Rendered

@nrc nrc added the T-lang Relevant to the language team, which will review and decide on the RFC. label May 1, 2016
@aturon
Copy link
Member

aturon commented Jul 28, 2016

Can you repoint this at the numbered RFC, rather than the 0000 file as it is currently?

(Sorry this has been sitting in the queue for so long...)

@arielb1
Copy link
Contributor

arielb1 commented Jul 31, 2016

@sgrif

But the impls do not specialize one another. When we get lattice specialization, we could just not require intersection impls.

@sgrif
Copy link
Contributor Author

sgrif commented Aug 1, 2016

@aturon Sorry not quite sure what you're asking, you want me to rename the file? Or you want me to edit the original RFC to include these changes?

@aturon
Copy link
Member

aturon commented Aug 27, 2016

@sgrif OK, so looking at this again, I have to agree with @arielb1 that I'm a bit worried about taking this route. In particular, at various points in the implementation we make assumptions about the specialization graph, and this would introduce cycles in that graph which could cause trouble.

I think that fundamentally we're going to need some special-casing here. FWIW, I don't think the original RFC particularly needs updating, since allowing overlap is still essentially what we want (and the rest is implementation detail).

I'd be happy to work with you and @nikomatsakis on an implementation plan and help mentor the actual work; we could set up a call if you're game.

Meantime, I suggest we close this RFC.

@sgrif
Copy link
Contributor Author

sgrif commented Aug 27, 2016

Yeah I'd be happy to work on that. Feel free to shoot me an email to set up.

@sgrif sgrif closed this Aug 27, 2016
@sgrif sgrif deleted the sg-amend-1268 branch August 31, 2016 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-lang Relevant to the language team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants