Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note of the RFC 2044 licensing process to README and update template #2075

Merged
merged 3 commits into from
Aug 2, 2017

Conversation

est31
Copy link
Member

@est31 est31 commented Jul 24, 2017

Also, add LICENSE-MIT and LICENSE-APACHE files to the repo.

@nrc nrc added the T-core Relevant to the core team, which will review and decide on the RFC. label Jul 25, 2017
0000-template.md Outdated
@@ -1,3 +1,14 @@
<!---
Copyright <fill in year> The Rust Project Developers. See the COPYRIGHT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't use "Copyright YYYY The Rust Project Developers. That isn't a legal entity. In the absence of copyright assignments (which don't seem like a good idea, and which the Rust project doesn't use in general), the copyrights would be held by the individual developers.

If you don't want to have people list individual copyright notices, you could just leave this part out and just keep the second paragraph. But please don't create a legally ambiguous situation by listing "The Rust Project Developers" as the copyright holder.

(You might, in an appropriate top-level file, note that copyrights are retained by the individual contributors. Listing every copyright holder is not strictly necessary from a legal perspective, though.)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, they probably copied it from rust-lang/rust, e.g. https://github.com/rust-lang/rust/blob/master/LICENSE-MIT#L1. Is that wrong too?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyb yes, probably :P

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddyb Yes, it is. I had a conversation about that with @brson a while back when a new such instance was added, and I thought some of them were addressed at that time (by switching to a notice that said something about copyrights being retained by contributors). But we need to address the rest of those notices.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I've copied it over (I've literally typed cp ../rust/LICENSE-* . in my shell :p).

I don't think that saying "The Rust Developers" implies that this is some legal entity of some sort, but rather a collection of individuals of which each one continues to be copyright owner. Maybe I could remove the capitalization so that this becomes more obvious. What do you think?

Personally I think its better to say "The Rust Developers" than providing and maintaining a list of individuals who have made copyright protected changes to a work. Often these lists are terribly inaccurate.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@est31 I absolutely agree that we shouldn't maintain an individual list. That's why I'm suggesting just saying "Copyrights are retained by the individual contributors.". Legally, copyright notices are not required (though they must be preserved if included); copyright occurs whether you have a notice or not. But a notice of the form "Copyright YYYY Some Name" is a legally recognized copyright notice, and it implies that the named entity owns the copyright. I'm suggesting avoiding that form, which has a specific legal meaning.

(There's nothing wrong with phrases like "The Rust Developers"; the problem is using them in a copyright notice.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshtriplett hmmm maybe we could switch to a phrase similar to the one that servo uses (with adjustments ofc):

/* This Source Code Form is subject to the terms of the Mozilla Public
 * License, v. 2.0. If a copy of the MPL was not distributed with this
 * file, You can obtain one at http://mozilla.org/MPL/2.0/. */

Generally I'd prefer to be consistent with rust-lang/rust headers, so maybe this could be discussed separately? We can change the header later on to whatever we agreed on to use in rust-lang/rust.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@est31 That would be entirely fine with me. I'd just like to get this sorted out before we further propagate it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be entirely fine with me.

Cool!

I'd just like to get this sorted out before we further propagate it.

I'd prefer to have this PR merged sooner rather than later, as until its merged, I'll have to add every new contributor to the list of people requried to sign off (I already had to add killercup as his RFC got merged after I made the initial list). And some people can't contribute as long as this PR is unmerged because they insisted on only agreeing to licensing their past (not past and future) contributions under the license...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@est31 I'm poking some folks right now about the rust-lang/rust repository. Meanwhile, would you have any objection to just dropping the first paragraph entirely, and only including the second, like this?

Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
<LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
option. This file may not be copied, modified, or distributed
except according to those terms. 

@aturon
Copy link
Member

aturon commented Jul 27, 2017

I wonder whether we should have a COPYRIGHT file like the main Rust repo, rather than (or in addition to) putting that information in the README. Thoughts?

cc @rust-lang/core

@est31
Copy link
Member Author

est31 commented Jul 27, 2017

@aturon when doing the PR I've wondered about that as well and decided on no because the COPYRIGHT file in the Rust repo consists of some notes about the copyright, and a list of licenses of third party code. As there is no third party stuff in this repo I've thought the COPYRIGHT file would be pretty empty, and my PR is already putting notes about copyright in the README, so it is documented.

@joshtriplett
Copy link
Member

Personally, I think the note in README suffices. rust-lang/rust needs COPYRIGHT mostly because of the various third-party licenses. In the absence of those third-party licenses, rust-lang/rust could just put the rest in the README.

@alexcrichton
Copy link
Member

As someone who's pretty ignorant to what all these files mean, I'm personally with the repo so long as it "look standard" in the sense that if you quickly glance at the repo you'll see a "LICENSE"-related thing at the top, so this seems sufficient for me at least!

@aturon aturon merged commit 76e011c into rust-lang:master Aug 2, 2017
@Centril Centril added the A-meta Proposals about how we make proposals label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Proposals about how we make proposals T-core Relevant to the core team, which will review and decide on the RFC.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants