Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a [lints] table to Cargo.toml #3389

Merged
merged 64 commits into from
May 9, 2023
Merged

Add a [lints] table to Cargo.toml #3389

merged 64 commits into from
May 9, 2023

Commits on Feb 14, 2023

  1. chore: Start manifest-lint RFC

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b80c2ff View commit details
    Browse the repository at this point in the history

  2. feat: Start manifest-lint RFC

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    28f51c3 View commit details
    Browse the repository at this point in the history

  3. fix: Remove stray paren

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    6ac518e View commit details
    Browse the repository at this point in the history

  4. fix: Pluralize the table

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    aa8695b View commit details
    Browse the repository at this point in the history

  5. fix: Make lints table top-level

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    680fe11 View commit details
    Browse the repository at this point in the history

  6. fix: Call out workspace lint name reservation

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    054de51 View commit details
    Browse the repository at this point in the history

  7. fix: Link to user-defined attribute RFC

    @epage
    epage committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    3796056 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. feat: Add a couple more brainstorming ideas

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    cfbd231 View commit details
    Browse the repository at this point in the history

  2. fix: Use correct --forbid syntax

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c57a510 View commit details
    Browse the repository at this point in the history

  3. fix: Apply ehuss' feedback

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    42010e8 View commit details
    Browse the repository at this point in the history

  4. fix: Add RFC number

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    b79b792 View commit details
    Browse the repository at this point in the history

  5. fix: Link out to rubocop

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4f4107f View commit details
    Browse the repository at this point in the history

  6. fix: Typos

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    bf6d9fc View commit details
    Browse the repository at this point in the history

  7. fix: Include cargo-cranky as prior art

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    d136690 View commit details
    Browse the repository at this point in the history

  8. fix: Typo

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    75198c2 View commit details
    Browse the repository at this point in the history

  9. fix: Be more explicit on workspace inheritance

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4a267a6 View commit details
    Browse the repository at this point in the history

  10. feat: Add external file possibility

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    c726cf3 View commit details
    Browse the repository at this point in the history

  11. feat: Add cargo lints as a future possibility

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    508e92f View commit details
    Browse the repository at this point in the history

  12. fix: Note that cargo-metadata support is needed for configurable lints

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    1c7ef77 View commit details
    Browse the repository at this point in the history

  13. fix: Update to lints.tool.lint

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    4bfc545 View commit details
    Browse the repository at this point in the history

  14. feat: Add open question about rustfmt

    @epage
    epage committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    f8071a3 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. fix: Discuss all supported lint tools

    @epage
    epage committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    1e43928 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. fix: Update for latest conversation 

    Note the confusion over rustfmt not reading `package.edition`.

Take a stab at resolving rustfmt by saying "no" and documenting it under
alternatives.

Be explicit on fingerprinting behavior and leave it out of the
Unresolved section.
    @epage
    epage committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    3cd6125 View commit details
    Browse the repository at this point in the history

  2. fix: Typo

    @epage
    epage committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    b02771a View commit details
    Browse the repository at this point in the history

  3. feat: Take a stab at lint precedence

    @epage
    epage committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    5a70d45 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. fix: Make priority signed, giving a clear center value

    @epage
    epage committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    08f7190 View commit details
    Browse the repository at this point in the history

  2. fix: Add another reason against 'rules'

    @epage
    epage committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    7d81bf1 View commit details
    Browse the repository at this point in the history

  3. fix: Some TOML formatting

    @epage
    epage committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    31c9587 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2023

  1. fix: Clarify we are overriding lint groups

    @epage
    epage committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    cf9a148 View commit details
    Browse the repository at this point in the history

  2. fix: Typo 

    Co-authored-by: teor <teor@riseup.net>
    @epage @teor2345
    epage and teor2345 committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    1adde1b View commit details
    Browse the repository at this point in the history

  3. fix: Document future idea for lint-level source

    @epage
    epage committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    78083ed View commit details
    Browse the repository at this point in the history

  4. fix: Typos

    @epage
    epage committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    72cdd44 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. fix: Spelling and language

    @epage
    epage committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    7073266 View commit details
    Browse the repository at this point in the history

  2. fix: remindme priority with multiple lint sources

    @epage
    epage committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    86b0b64 View commit details
    Browse the repository at this point in the history

  3. fix: Be explicit that lints does not affect dependencies

    @epage
    epage committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    a270d28 View commit details
    Browse the repository at this point in the history

  4. fix: Typo

    @epage
    epage committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    78ab70d View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2023

  1. fix: Expand on lint source future

    @epage
    epage committed Feb 28, 2023
    Configuration menu
    Copy the full SHA
    cf93e59 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. fix: Isolate array precedence

    @epage
    epage committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    e92a52b View commit details
    Browse the repository at this point in the history

  2. fix: Document 'auto-priority' alternative

    @epage
    epage committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    ef224ec View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2023

  1. fix: Add missing namespacing of rust lints

    @epage
    epage committed Mar 18, 2023
    Configuration menu
    Copy the full SHA
    ef4a490 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2023

  1. fix: Call out rust/rustc category confusion

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    86932bd View commit details
    Browse the repository at this point in the history

  2. fix: Be more explicit in how the lints table is loaded

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    5afa0cf View commit details
    Browse the repository at this point in the history

  3. fix: Clarified this isn't limited to rustc/clippy

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    a54d985 View commit details
    Browse the repository at this point in the history

  4. fix: Explicitly call out why rust table exists'

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    de44058 View commit details
    Browse the repository at this point in the history

  5. fix: Clarify I meant lint levels, not general lint configuration

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    1557767 View commit details
    Browse the repository at this point in the history

  6. fix: Clarify clippy.toml isn't going away yet

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    e1230cd View commit details
    Browse the repository at this point in the history

  7. fix: Add clarification that an example is only an example

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    2f5f873 View commit details
    Browse the repository at this point in the history

  8. fix: Be explicit that lint configuration is a future possibility

    @epage
    epage committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    3543967 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2023

  1. fix: Update now that we have confirmation on ruff's design choice

    @epage
    epage committed Mar 29, 2023
    Configuration menu
    Copy the full SHA
    45766c4 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2023

  1. fix: Expand on why not :: but separate tables

    @epage
    epage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    fbf6f48 View commit details
    Browse the repository at this point in the history

  2. fix: Expand more on why not level=lint

    @epage
    epage committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    935593f View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. fix: Remove confusion over :: and tool-config

    @epage
    epage committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    c3f932c View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. fix: Add auto-sort as a future possibility

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    e73e6b9 View commit details
    Browse the repository at this point in the history

  2. fix: Add high-level guidance

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    d32801b View commit details
    Browse the repository at this point in the history

  3. refactor: Break up Rationale / Alts into smaller sections

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    330782a View commit details
    Browse the repository at this point in the history

  4. fix: Rewrite :: section

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    9cbc977 View commit details
    Browse the repository at this point in the history

  5. fix: Typos

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    2f1b799 View commit details
    Browse the repository at this point in the history

  6. fix: Expand the schema section

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    660bcdb View commit details
    Browse the repository at this point in the history

  7. fix: Expand on precedence options

    @epage
    epage committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    28f14ef View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. fix: Move some discussion to stablization

    @epage
    epage committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    51f4984 View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2023

  1. fix: Be more precise when talking about disjoint groups

    @epage
    epage committed Apr 19, 2023
    Configuration menu
    Copy the full SHA
    2b10a5e View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2023

  1. fix: Clarify dependency situation

    @epage
    epage committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    4cb8421 View commit details
    Browse the repository at this point in the history

  2. fix: Call out reducing rebuilds for filtering lints

    @epage
    epage committed Apr 27, 2023
    Configuration menu
    Copy the full SHA
    a47520f View commit details
    Browse the repository at this point in the history

Commits on May 9, 2023

  1. Add tracking issue.

    @ehuss
    ehuss committed May 9, 2023
    Configuration menu
    Copy the full SHA
    7aab0bd View commit details
    Browse the repository at this point in the history