Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

both the RFC file name and link in the file should be updated #3622

Merged
merged 1 commit into from
May 2, 2024

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented May 2, 2024

At least I assume this is the intention? It seems strange to update the file but not the link in said file.

@RalfJung
Copy link
Member Author

RalfJung commented May 2, 2024

One annoying aspect of this renaming business is that the "Rendered" link that rfcbot adds will then be dangling. Should the README say to update the link?

Cc rust-lang/triagebot#1803

@ehuss ehuss added the not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc. label May 2, 2024
Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, thanks!

@ehuss ehuss merged commit 8e7887c into rust-lang:master May 2, 2024
@RalfJung RalfJung deleted the rfc-process-pr-number branch May 2, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not-rfc For PRs that fix things like spelling mistakes, wrong file names, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants