Only emit save-analysis data for cargo build tasks

[nrc]

Previously, we were emittinng analysis data for all tasks, including doc. That meant we got two sets of save-analysis data, one from the normal build and one from the docs. That means indexing with the RLS took twice as long and made downloads larger and build times longer.

cc rust-lang/rls#826

r? @Mark-Simulacrum

[rust-highfive]

Your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[00:00:47] configure: rust.quiet-tests     := True
---
[00:04:35] tidy error: /checkout/src/bootstrap/builder.rs:759: line longer than 100 chars
[00:04:37] some tidy checks failed
[00:04:37]
[00:04:37]
[00:04:37] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:37] expected success, got: exit code: 1
[00:04:37]
[00:04:37]
[00:04:37] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:37] Build completed unsuccessfully in 0:01:53
[00:04:37] Makefile:79: recipe for target 'tidy' failed
[00:04:37] make: *** [tidy] Error 1
---
$ ls -lat $HOME/Library/Logs/DiagnosticReports/
ls: cannot access /home/travis/Library/Logs/DiagnosticReports/: No such file or directory
travis_time:end:172b9938:start=1523957989419402533,finish=1523957989425602056,duration=6199523
travis_fold:end:after_failure.2
travis_fold:start:after_failure.3
travis_time:start:16e04628
$ find $HOME/Library/Logs/DiagnosticReports -type f -name '*.crash' -not -name '*.stage2-*.crash' -not -name 'com.apple.CoreSimulator.CoreSimulatorService-*.crash' -exec printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" {} \; -exec head -750 {} \; -exec echo travis_fold":"end:crashlog \; || true
find: `/home/travis/Library/Logs/DiagnosticReports': No such file or directory
travis_time:end:16e04628:start=1523957989431012820,finish=1523957989437184018,duration=6171198
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0ec41225
$ dmesg | grep -i kill
[   10.423312] init: failsafe main process (1095) killed by TERM signal

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

[nrc]

Note the test failure was for an earlier commit that I force-pushed over, currently passing Travis.

[Mark-Simulacrum]

Seems fine to me; just to check though this shouldn't cause problems for doxidize or the like, correct? That is, despite them wanting to run in cargo doc mode they should still have the relevant std analysis data.

If that's not a concern, r=me.

[nrc]

@Mark-Simulacrum this only affects Rust build, so it shouldn't affect Doxidize. We would need to expand the check to "build" || "check" in that case, but there would be plenty of other changes needed to add Doxidize and that is certainly a way off.

@bors: r=mark-simulacrum

[bors]

📌 Commit de34735 has been approved by mark-simulacrum

[bors]

⌛ Testing commit de34735 with merge e0f9b32...

[bors]

☀️ Test successful - status-appveyor, status-travis
Approved by: mark-simulacrum
Pushing e0f9b32 to master...