Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

filter before add --error-format #1471

Closed
wants to merge 1 commit into from

Conversation

scturtle
Copy link
Contributor

@scturtle scturtle commented Jun 2, 2019

To work around error: Option 'error-format' given more than once.

rls/src/build/cargo.rs Outdated Show resolved Hide resolved
@Xanewok
Copy link
Member

Xanewok commented Jun 19, 2019

IIRC that's to work around --error-format being passed with CARGO_PIPELINING (?) enabled in Cargo, no?

I think it'd be good to extract a helper function that does that since it's not immediately obvious what's happening and why. Could you extract a function that given the arguments and the key to skip (--error-format in this case) returns the new arguments instead? I think it'd help with readability, also with a comment on why we have to do that.

@Xanewok
Copy link
Member

Xanewok commented Jun 24, 2019

cc #1484

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants