Skip to content

Commit

Permalink
Auto merge of #15333 - davidbarsky:davidbarsky/downgrade-vscode-to-1.…
Browse files Browse the repository at this point in the history
…75, r=lnicola

vscode: change minimum VS Code version to 1.75 from 1.78

I previously mentioned [in a comment](#15265 (comment)) that folks at my employer are on 1.78, but I was incorrect: people are on 1.75. I know this is outside the standard version support policy, but I haven't seen any of the new features in VS Code be used in rust-analyzer. The most applicable feature in those three versions of VS Code that I can find [is lazily resolving code actions](https://code.visualstudio.com/updates/v1_78#_resolve-code-action-commands-in-resolvecodeaction), but it doesn't seem like rust-analyzer is making use of that feature.

(I'll be posting a PR that adds support for `$saved_file` within the next day, so feel free to bump the minimum VS Code version back to 1.78 if/when that PR lands. This just makes vendoring the _actual_ change I'm interested in a little bit easier.)
  • Loading branch information
bors committed Jul 24, 2023
2 parents febb3b3 + ba72216 commit b64e5b3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
10 changes: 5 additions & 5 deletions editors/code/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions editors/code/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
}
},
"engines": {
"vscode": "^1.78.0"
"vscode": "^1.75.0"
},
"enabledApiProposals": [],
"scripts": {
Expand All @@ -53,7 +53,7 @@
"devDependencies": {
"@tsconfig/strictest": "^2.0.1",
"@types/node": "~16.11.7",
"@types/vscode": "~1.78.1",
"@types/vscode": "~1.75",
"@typescript-eslint/eslint-plugin": "^6.0.0",
"@typescript-eslint/parser": "^6.0.0",
"@vscode/test-electron": "^2.3.3",
Expand Down

0 comments on commit b64e5b3

Please sign in to comment.