minor: vscode: change minimum VS Code version to 1.75 from 1.78 #15333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
|
cc: @tetsuharuohzeki |
|
Alright, but I'm not a fan of the process here. @bors r+ |
Neither am I, honestly. What would be a less burdensome one for you? |
|
☀️ Test successful - checks-actions |
It's not burdensome, just feels like the wrong thing to do. But it's all right for now (until it actually becomes so). |
lnicola
changed the title
lnicola
changed the title
bors
added a commit
that referenced
this pull request
Nov 15, 2023
…rsion-to-1.78, r=lnicola editor/code: bump minimum version of VS Code to 1.78 Undoes #15333.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I previously mentioned in a comment that folks at my employer are on 1.78, but I was incorrect: people are on 1.75. I know this is outside the standard version support policy, but I haven't seen any of the new features in VS Code be used in rust-analyzer. The most applicable feature in those three versions of VS Code that I can find is lazily resolving code actions, but it doesn't seem like rust-analyzer is making use of that feature.
(I'll be posting a PR that adds support for
$saved_filewithin the next day, so feel free to bump the minimum VS Code version back to 1.78 if/when that PR lands. This just makes vendoring the actual change I'm interested in a little bit easier.)