Goto definition on macro-by-example call should jump to the macro arm that matches #4028

matklad · 2020-04-18T10:44:14Z

macro_rules! m {
  (a) => ();
  (b) => (); // .. should land here
}

m!(b);  // goto def here ...

Not something we need to implement right now, but eventually I'd love to see this

Render matched macro arm on hover of macro calls Fixes rust-lang/rust-analyzer#4028, its a different take on the idea. I don't like go to being changed here simply because we can't point the focus range on the name anymore as we usually do, and some editors might use this feature (and the focus range) for certain other things. We could instead add a new hover action for this to move to the arm directly (or maybe make `go to implementation` jump to the arm?)

matklad added E-hard fun A technically challenging issue with high impact labels Apr 18, 2020

lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 22, 2021

Veykril added the A-macro macro expansion label May 25, 2022

Veykril self-assigned this Dec 6, 2023

Veykril mentioned this issue Dec 8, 2023

Render matched macro arm on hover of macro calls #16057

Merged

bors closed this as completed in 08c706f Apr 18, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Goto definition on macro-by-example call should jump to the macro arm that matches #4028

Goto definition on macro-by-example call should jump to the macro arm that matches #4028

matklad commented Apr 18, 2020

Goto definition on macro-by-example call should jump to the macro arm that matches #4028

Goto definition on macro-by-example call should jump to the macro arm that matches #4028

Comments

matklad commented Apr 18, 2020