Insert #[must_use] on generate_new #11738
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Umm #11737 |
|
😆 you're fast! |
|
Oof, sorry 😞. We should probably check the other code generation assists, there might be other cases like this. |
|
<3 all good, thanks for making rust-analyzer better! |
|
Yeah, so |
|
Happy to help! Maybe you pick the first one and I'll do the other two? |
|
Sure :-) |
bors bot
added a commit
that referenced
this pull request
Mar 17, 2022
11737: Emit `#[must_use]` in `Generate new` assist r=lnicola a=lnicola Closes #11736 11739: Insert #[must_use] in generate_getter r=lnicola a=Walther Inserts `#[must_use]` for the generated getter methods. From discussion in #11736 and #11738 Co-authored-by: Laurențiu Nicola <lnicola@dend.ro> Co-authored-by: Walther <veeti.haapsamo@gmail.com>
bors bot
added a commit
that referenced
this pull request
Mar 17, 2022
11740: Insert #[must_use] in generate_is_empty_from_len r=lnicola a=Walther Inserts `#[must_use]` for the generated `is_empty` methods. I also added the `#[must_use]` for the `len()` methods in the documentation examples and tests for this generator while at it, to make sure they too encourage the use of the annotation. From discussion in #11736 and #11738 Co-authored-by: Walther <veeti.haapsamo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11736